MDEV-35184 Corruption errors upon creation or usage of Federated table with vector key

disallow vector indexes in FederatedX, both in normal create
and in assisted discovery

Author: vuvova

mysql-test/suite/federated/federatedx.result

@@ -2374,6 +2374,19 @@ a
 DROP VIEW v;
 DROP TABLE t1_fed, t1, t2;
 DROP SERVER s;
+# End of 11.0 tests
+#
+# MDEV-35184 Corruption errors upon creation or usage of Federated table with vector key
+#
+create server s foreign data wrapper mysql options (host "127.0.0.1", database "test", user "root", port $MASTER_MYPORT);
+create table t1 (a vector(1) not null, vector(a));
+create table t1_fed1 engine=federated connection = 's/t1';
+ERROR HY000: Table storage engine 'FEDERATEDX' does not support the create option 'VECTOR'
+create table t1_fed2 (a vector(1) not null, vector(a)) engine=federated connection = 's/t1';
+ERROR HY000: Table storage engine 'FEDERATEDX' does not support the create option 'VECTOR'
+drop table t1;
+drop server s;
+# End of 11.8 tests
 connection master;
 DROP TABLE IF EXISTS federated.t1;
 DROP DATABASE IF EXISTS federated;

mysql-test/suite/federated/federatedx.test

@@ -2112,4 +2112,20 @@ DROP VIEW v;
 DROP TABLE t1_fed, t1, t2;
 DROP SERVER s;
 
+--echo # End of 11.0 tests
+
+--echo #
+--echo # MDEV-35184 Corruption errors upon creation or usage of Federated table with vector key
+--echo #
+evalp create server s foreign data wrapper mysql options (host "127.0.0.1", database "test", user "root", port $MASTER_MYPORT);
+create table t1 (a vector(1) not null, vector(a));
+--error ER_ILLEGAL_HA_CREATE_OPTION
+create table t1_fed1 engine=federated connection = 's/t1';
+--error ER_ILLEGAL_HA_CREATE_OPTION
+create table t1_fed2 (a vector(1) not null, vector(a)) engine=federated connection = 's/t1';
+drop table t1;
+drop server s;
+
+--echo # End of 11.8 tests
+
 source include/federated_cleanup.inc;

storage/federated/ha_federated.cc

@@ -3128,6 +3128,12 @@ int ha_federated::create(const char *name, TABLE *table_arg,
   FEDERATED_SHARE tmp_share; // Only a temporary share, to test the url
   DBUG_ENTER("ha_federated::create");
 
+  if (table_arg->s->hlindexes())
+  {
+    my_error(ER_ILLEGAL_HA_CREATE_OPTION, MYF(0), "FEDERATED", "VECTOR");
+    DBUG_RETURN(HA_ERR_UNSUPPORTED);
+  }
+
   retval= parse_url(thd->mem_root, &tmp_share, table_arg, 1);
 
   DBUG_RETURN(retval);

storage/federatedx/ha_federatedx.cc

@@ -3403,6 +3403,12 @@ int ha_federatedx::create(const char *name, TABLE *table_arg,
   federatedx_io *tmp_io= NULL;
   DBUG_ENTER("ha_federatedx::create");
 
+  if (table_arg->s->hlindexes())
+  {
+    my_error(ER_ILLEGAL_HA_CREATE_OPTION, MYF(0), "FEDERATEDX", "VECTOR");
+    DBUG_RETURN(HA_ERR_UNSUPPORTED);
+  }
+
   if ((retval= parse_url(thd->mem_root, &tmp_share, table_arg->s, 1)))
     goto error;
 
@@ -3706,6 +3712,15 @@ int ha_federatedx::discover_assisted(handlerton *hton, THD* thd,
 err1:
   if (error)
     my_error(ER_CONNECT_TO_FOREIGN_DATA_SOURCE, MYF(0), mysql_error(&mysql));
+  else if ((error= table_s->hlindexes()))
+  {
+    my_error(ER_ILLEGAL_HA_CREATE_OPTION, MYF(0), "FEDERATEDX", "VECTOR");
+    char file_name[FN_REFLEN+1];
+    strxnmov(file_name, sizeof(file_name)-1, table_s->normalized_path.str,
+             reg_ext, NullS);
+    my_delete(file_name, MYF(0));
+    plugin_unlock(0, table_s->db_plugin);
+  }
   mysql_close(&mysql);
   return error;
 }