Skip to content

Commit 3f8df01

Browse files
committed
MDEV-25425 Useless message "If the mysqld execution user is authorized page cleaner thread priority can be changed."
On startup, InnoDB tried to increase the priority of the page cleaner thread. This would usually fail, resulting in a server log message. When the page cleaner code was refactored in MDEV-23855, the throughput and latency were greatly improved even when the buf_flush_page_cleaner thread always ran the same priority with other threads in our benchmarks. So, this code should have no benefit in MariaDB Server 10.5.7 or later. Besides, starting with MariaDB Server 10.5, the executable is called mariadbd, not mysqld.
1 parent de74630 commit 3f8df01

File tree

1 file changed

+0
-22
lines changed

1 file changed

+0
-22
lines changed

storage/innobase/buf/buf0flu.cc

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -40,13 +40,6 @@ Created 11/11/1995 Heikki Tuuri
4040
#include "log0crypt.h"
4141
#include "srv0mon.h"
4242
#include "fil0pagecompress.h"
43-
#ifdef UNIV_LINUX
44-
/* include defs for CPU time priority settings */
45-
#include <unistd.h>
46-
#include <sys/syscall.h>
47-
#include <sys/time.h>
48-
#include <sys/resource.h>
49-
#endif /* UNIV_LINUX */
5043
#ifdef HAVE_LZO
5144
# include "lzo/lzo1x.h"
5245
#elif defined HAVE_SNAPPY
@@ -2083,21 +2076,6 @@ static os_thread_ret_t DECLARE_THREAD(buf_flush_page_cleaner)(void*)
20832076
ut_ad(!srv_read_only_mode);
20842077
ut_ad(buf_page_cleaner_is_active);
20852078

2086-
#ifdef UNIV_DEBUG_THREAD_CREATION
2087-
ib::info() << "page_cleaner thread running, id "
2088-
<< os_thread_get_curr_id();
2089-
#endif /* UNIV_DEBUG_THREAD_CREATION */
2090-
#ifdef UNIV_LINUX
2091-
/* linux might be able to set different setting for each thread.
2092-
worth to try to set high priority for the page cleaner thread */
2093-
const pid_t tid= static_cast<pid_t>(syscall(SYS_gettid));
2094-
setpriority(PRIO_PROCESS, tid, -20);
2095-
if (getpriority(PRIO_PROCESS, tid) != -20)
2096-
ib::info() << "If the mysqld execution user is authorized,"
2097-
" page cleaner thread priority can be changed."
2098-
" See the man page of setpriority().";
2099-
#endif /* UNIV_LINUX */
2100-
21012079
ulint last_pages= 0;
21022080
timespec abstime;
21032081
set_timespec(abstime, 1);

0 commit comments

Comments
 (0)