Skip to content

Commit 40b743f

Browse files
committed
remove redundant select in the perfschema.show_aggregate test
instead, include handler_rollback in the following per-connection selects
1 parent b42158b commit 40b743f

File tree

2 files changed

+15
-22
lines changed

2 files changed

+15
-22
lines changed

mysql-test/suite/perfschema/r/show_aggregate.result

Lines changed: 9 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -201,28 +201,23 @@ SET sr.acct = sr.a1 + sr.a2 + sr.a3;
201201
# Review per-thread status counts
202202
#
203203
USE performance_schema;
204-
SELECT * FROM status_by_thread WHERE thread_id IN (@con1_id, @con2_id, @con3_id) AND variable_name IN ('handler_delete', 'handler_rollback') ORDER BY thread_id;
205-
THREAD_ID VARIABLE_NAME VARIABLE_VALUE
206-
thread_id Handler_delete 1
207-
thread_id Handler_rollback 1
208-
thread_id Handler_delete 2
209-
thread_id Handler_rollback 2
210-
thread_id Handler_delete 3
211-
thread_id Handler_rollback 3
212204
#
213205
# Verify expected counts for 'handler_delete' per thread
214206
#
215-
SELECT *, IF (variable_value = 1,'OK','ERROR') AS Expected FROM status_by_thread WHERE thread_id = @con1_id AND variable_name IN ('handler_delete');
207+
SELECT *, IF (variable_value = 1,'OK','ERROR') AS Expected FROM status_by_thread WHERE thread_id = @con1_id AND variable_name IN ('handler_delete', 'handler_rollback');
216208
THREAD_ID VARIABLE_NAME VARIABLE_VALUE Expected
217-
connect_1 Handler_delete 1 OK
209+
con_1 Handler_delete 1 OK
210+
con_1 Handler_rollback 1 OK
218211
#
219-
SELECT *, IF (variable_value = 2,'OK','ERROR') AS Expected FROM status_by_thread WHERE thread_id = @con2_id AND variable_name IN ('handler_delete');
212+
SELECT *, IF (variable_value = 2,'OK','ERROR') AS Expected FROM status_by_thread WHERE thread_id = @con2_id AND variable_name IN ('handler_delete', 'handler_rollback');
220213
THREAD_ID VARIABLE_NAME VARIABLE_VALUE Expected
221-
connnect_2 Handler_delete 2 OK
214+
con_2 Handler_delete 2 OK
215+
con_2 Handler_rollback 2 OK
222216
#
223-
SELECT *, IF (variable_value = 3,'OK','ERROR') AS Expected FROM status_by_thread WHERE thread_id = @con3_id AND variable_name IN ('handler_delete');
217+
SELECT *, IF (variable_value = 3,'OK','ERROR') AS Expected FROM status_by_thread WHERE thread_id = @con3_id AND variable_name IN ('handler_delete', 'handler_rollback');
224218
THREAD_ID VARIABLE_NAME VARIABLE_VALUE Expected
225-
connnect_3 Handler_delete 3 OK
219+
con_3 Handler_delete 3 OK
220+
con_3 Handler_rollback 3 OK
226221
#
227222
# STATUS_BY_THREAD vs. GLOBAL_STATUS
228223
#

mysql-test/suite/perfschema/t/show_aggregate.test

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -130,20 +130,18 @@ SELECT thread_id INTO @con3_id FROM threads WHERE processlist_user IN ('user3');
130130
--echo # Review per-thread status counts
131131
--echo #
132132
USE performance_schema;
133-
--replace_column 1 thread_id
134-
SELECT * FROM status_by_thread WHERE thread_id IN (@con1_id, @con2_id, @con3_id) AND variable_name IN ('handler_delete', 'handler_rollback') ORDER BY thread_id;
135133

136134
--echo #
137135
--echo # Verify expected counts for 'handler_delete' per thread
138136
--echo #
139-
--replace_column 1 connect_1
140-
SELECT *, IF (variable_value = 1,'OK','ERROR') AS Expected FROM status_by_thread WHERE thread_id = @con1_id AND variable_name IN ('handler_delete');
137+
--replace_column 1 con_1
138+
SELECT *, IF (variable_value = 1,'OK','ERROR') AS Expected FROM status_by_thread WHERE thread_id = @con1_id AND variable_name IN ('handler_delete', 'handler_rollback');
141139
--echo #
142-
--replace_column 1 connnect_2
143-
SELECT *, IF (variable_value = 2,'OK','ERROR') AS Expected FROM status_by_thread WHERE thread_id = @con2_id AND variable_name IN ('handler_delete');
140+
--replace_column 1 con_2
141+
SELECT *, IF (variable_value = 2,'OK','ERROR') AS Expected FROM status_by_thread WHERE thread_id = @con2_id AND variable_name IN ('handler_delete', 'handler_rollback');
144142
--echo #
145-
--replace_column 1 connnect_3
146-
SELECT *, IF (variable_value = 3,'OK','ERROR') AS Expected FROM status_by_thread WHERE thread_id = @con3_id AND variable_name IN ('handler_delete');
143+
--replace_column 1 con_3
144+
SELECT *, IF (variable_value = 3,'OK','ERROR') AS Expected FROM status_by_thread WHERE thread_id = @con3_id AND variable_name IN ('handler_delete', 'handler_rollback');
147145

148146
--echo #
149147
--echo # STATUS_BY_THREAD vs. GLOBAL_STATUS

0 commit comments

Comments
 (0)