MDEV-18269 - fix off-by-one bug in unittest

ncopa · svoj · commit 459d6da86955 · 2019-01-16T23:41:57.000+04:00
Fix the off-by-one overflow which was introduced with commit b0fd06a (MDEV-15670 - unit.my_atomic failed in buildbot with Signal 11 thrown) Closes #1098.
diff --git a/unittest/mysys/thr_template.c b/unittest/mysys/thr_template.c
@@ -34,7 +34,7 @@ void test_concurrently(const char *test, pthread_handler handler, int n, int m)
   bad= 0;
 
   diag("Testing %s with %d threads, %d iterations... ", test, n, m);
-  for (i= n; i; i--)
+  for (i= 0; i < n; i++)
   {
     if (pthread_create(&threads[i], 0, handler, &m) != 0)
     {
@@ -43,7 +43,7 @@ void test_concurrently(const char *test, pthread_handler handler, int n, int m)
     }
   }
 
-  for (i= n; i; i--)
+  for (i= 0; i < n; i++)
     pthread_join(threads[i], 0);
 
   now= my_interval_timer() - now;

Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ void test_concurrently(const char *test, pthread_handler handler, int n, int m)`
`34`	`34`	`bad= 0;`
`35`	`35`
`36`	`36`	`diag("Testing %s with %d threads, %d iterations... ", test, n, m);`
`37`		`- for (i= n; i; i--)`
	`37`	`+ for (i= 0; i < n; i++)`
`38`	`38`	`{`
`39`	`39`	`if (pthread_create(&threads[i], 0, handler, &m) != 0)`
`40`	`40`	`{`
`@@ -43,7 +43,7 @@ void test_concurrently(const char *test, pthread_handler handler, int n, int m)`
`43`	`43`	`}`
`44`	`44`	`}`
`45`	`45`
`46`		`- for (i= n; i; i--)`
	`46`	`+ for (i= 0; i < n; i++)`
`47`	`47`	`pthread_join(threads[i], 0);`
`48`	`48`
`49`	`49`	`now= my_interval_timer() - now;`