Windows/ARM64 - workaround compiler bug

vaintroub · vaintroub · commit 4af231b1d113 · 2025-05-26T12:02:04.000+02:00
Follow-up 9e1c1d4 Item_func_hybrid_field_type::val_real_from_int_op() might return wrong result. This makes mtr fail on Windows/ARM , at least in main.func_format and main.sp-vars Many to Chengya/coneco-cy for debugging the issue and finding the cause.
diff --git a/sql/item_func.cc b/sql/item_func.cc
@@ -843,12 +843,22 @@ String *Item_func_hybrid_field_type::val_str_from_int_op(String *str)
   return str;
 }
 
+#ifdef _M_ARM64
+/* MSVC on ARM incorrectly optimizes the code in val_real_from_int_op() */
+#pragma optimize("", off)
+#endif
+
 double Item_func_hybrid_field_type::val_real_from_int_op()
 {
   longlong result= int_op();
   return unsigned_flag ? (double) ((ulonglong) result) : (double) result;
 }
 
+#ifdef _M_ARM64
+#pragma optimize("", on)
+#endif
+
+
 my_decimal *
 Item_func_hybrid_field_type::val_decimal_from_int_op(my_decimal *dec)
 {

Original file line number	Diff line number	Diff line change
`@@ -843,12 +843,22 @@ String Item_func_hybrid_field_type::val_str_from_int_op(String str)`
`843`	`843`	`return str;`
`844`	`844`	`}`
`845`	`845`
	`846`	`+#ifdef _M_ARM64`
	`847`	`+/* MSVC on ARM incorrectly optimizes the code in val_real_from_int_op() */`
	`848`	`+#pragma optimize("", off)`
	`849`	`+#endif`
	`850`	`+`
`846`	`851`	`double Item_func_hybrid_field_type::val_real_from_int_op()`
`847`	`852`	`{`
`848`	`853`	`longlong result= int_op();`
`849`	`854`	`return unsigned_flag ? (double) ((ulonglong) result) : (double) result;`
`850`	`855`	`}`
`851`	`856`
	`857`	`+#ifdef _M_ARM64`
	`858`	`+#pragma optimize("", on)`
	`859`	`+#endif`
	`860`	`+`
	`861`	`+`
`852`	`862`	`my_decimal *`
`853`	`863`	`Item_func_hybrid_field_type::val_decimal_from_int_op(my_decimal *dec)`
`854`	`864`	`{`