Skip to content
Permalink
Browse files
MDEV-23584 : Galera assertion failure "thd->transaction.stmt.is_empty…
…() at transaction.cc:69

If statement still contains changes it must be committed
before actual transaction is committed.

This assertion was found using randgen and happens only on
applier. No repeatable test case found.
  • Loading branch information
Jan Lindström committed Aug 26, 2020
1 parent 1e08e08 commit 571764c
Showing 1 changed file with 7 additions and 1 deletion.
@@ -301,9 +301,15 @@ int Wsrep_high_priority_service::commit(const wsrep::ws_handle& ws_handle,
DBUG_ASSERT(thd->wsrep_trx().active());
thd->wsrep_cs().prepare_for_ordering(ws_handle, ws_meta, true);
thd_proc_info(thd, "committing");
int ret=0;

const bool is_ordered= !ws_meta.seqno().is_undefined();
int ret= trans_commit(thd);

if (!thd->transaction.stmt.is_empty())
ret= trans_commit_stmt(thd);

if (ret == 0)
ret= trans_commit(thd);

if (ret == 0)
{

0 comments on commit 571764c

Please sign in to comment.