Skip to content

Commit 59ea645

Browse files
committed
Minor cleanup of innodb.innodb-change-buffer-recovery
This should be a non-functional change. I was unable to repeat MDEV-11626 innodb.innodb-change-buffer-recovery fails for xtradb and cannot determine the reason for the failure without having access to the files. The repeatability of MDEV-11626 should not be affected by these changes.
1 parent 384f4d1 commit 59ea645

File tree

2 files changed

+10
-18
lines changed

2 files changed

+10
-18
lines changed

mysql-test/suite/innodb/r/innodb-change-buffer-recovery.result

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ a INT AUTO_INCREMENT PRIMARY KEY,
88
b CHAR(1),
99
c INT,
1010
INDEX(b))
11-
ENGINE=InnoDB;
11+
ENGINE=InnoDB STATS_PERSISTENT=0;
1212
INSERT INTO t1 VALUES(0,'x',1);
1313
INSERT INTO t1 SELECT 0,b,c FROM t1;
1414
INSERT INTO t1 SELECT 0,b,c FROM t1;

mysql-test/suite/innodb/t/innodb-change-buffer-recovery.test

Lines changed: 9 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,3 @@
1-
if (`select plugin_auth_version < "5.6.17" from information_schema.plugins where plugin_name='innodb'`)
2-
{
3-
--skip Not fixed in InnoDB before 5.6.17
4-
}
5-
61
--echo #
72
--echo # Bug#69122 - INNODB DOESN'T REDO-LOG INSERT BUFFER MERGE
83
--echo # OPERATION IF IT IS DONE IN-PLACE
@@ -14,8 +9,9 @@ if (`select plugin_auth_version < "5.6.17" from information_schema.plugins where
149
--source include/not_embedded.inc
1510
# DBUG_SUICIDE() hangs under valgrind
1611
--source include/not_valgrind.inc
17-
# No windows, need perl
18-
--source include/not_windows.inc
12+
13+
--let $_server_id= `SELECT @@server_id`
14+
--let $_expect_file_name= $MYSQLTEST_VARDIR/tmp/mysqld.$_server_id.expect
1915

2016
# The flag innodb_change_buffering_debug is only available in debug builds.
2117
# It instructs InnoDB to try to evict pages from the buffer pool when
@@ -29,7 +25,7 @@ CREATE TABLE t1(
2925
b CHAR(1),
3026
c INT,
3127
INDEX(b))
32-
ENGINE=InnoDB;
28+
ENGINE=InnoDB STATS_PERSISTENT=0;
3329

3430
# Create enough rows for the table, so that the change buffer will be
3531
# used for modifying the secondary index page. There must be multiple
@@ -54,27 +50,23 @@ BEGIN;
5450
SELECT b FROM t1 LIMIT 3;
5551

5652
connect (con1,localhost,root,,);
57-
connection con1;
5853
BEGIN;
5954
DELETE FROM t1 WHERE a=1;
6055
# This should be buffered, if innodb_change_buffering_debug = 1 is in effect.
6156
INSERT INTO t1 VALUES(1,'X',1);
6257

6358
SET DEBUG_DBUG='+d,crash_after_log_ibuf_upd_inplace';
64-
--exec echo "wait" > $MYSQLTEST_VARDIR/tmp/mysqld.1.expect
59+
60+
--exec echo "wait" > $_expect_file_name
6561
--error 2013
6662
# This should force a change buffer merge
6763
SELECT b FROM t1 LIMIT 3;
64+
disconnect con1;
65+
connection default;
6866

6967
let SEARCH_PATTERN=Wrote log record for ibuf update in place operation;
7068
--source include/search_pattern_in_file.inc
71-
72-
# Write file to make mysql-test-run.pl start up the server again
73-
--exec echo "restart" > $MYSQLTEST_VARDIR/tmp/mysqld.1.expect
74-
--enable_reconnect
75-
--source include/wait_until_connected_again.inc
69+
--source include/start_mysqld.inc
7670

7771
CHECK TABLE t1;
78-
79-
# Cleanup
8072
DROP TABLE t1;

0 commit comments

Comments
 (0)