Skip to content

Commit 6bc75a4

Browse files
committed
MDEV-15528 preparation: Remove a constant parameter
fsp_free_seg_inode(): Remove the constant parameter log=true. Only fsp_free_page() could also be called with log=false. The dead code was introduced in commit 304ae94 by me, and spotted by Thirunarayanan Balathandayuthapani.
1 parent c339487 commit 6bc75a4

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

storage/innobase/fsp/fsp0fsp.cc

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1644,12 +1644,10 @@ fsp_alloc_seg_inode(
16441644
/** Frees a file segment inode.
16451645
@param[in,out] space tablespace
16461646
@param[in,out] inode segment inode
1647-
@param[in] log whether to write MLOG_INIT_FREE_PAGE record
16481647
@param[in,out] mtr mini-transaction */
16491648
static void fsp_free_seg_inode(
16501649
fil_space_t* space,
16511650
fseg_inode_t* inode,
1652-
bool log,
16531651
mtr_t* mtr)
16541652
{
16551653
page_t* page;
@@ -1688,7 +1686,7 @@ static void fsp_free_seg_inode(
16881686
flst_remove(space_header + FSP_SEG_INODES_FREE,
16891687
page + FSEG_INODE_PAGE_NODE, mtr);
16901688

1691-
fsp_free_page(space, page_get_page_no(page), log, mtr);
1689+
fsp_free_page(space, page_get_page_no(page), true, mtr);
16921690
}
16931691
}
16941692

@@ -1971,7 +1969,7 @@ fseg_create(
19711969
ut_ad(!has_done_reservation || block != NULL);
19721970

19731971
if (block == NULL) {
1974-
fsp_free_seg_inode(space, inode, true, mtr);
1972+
fsp_free_seg_inode(space, inode, mtr);
19751973
goto funct_exit;
19761974
}
19771975

@@ -3083,7 +3081,7 @@ fseg_free_step_func(
30833081

30843082
if (n == ULINT_UNDEFINED) {
30853083
/* Freeing completed: free the segment inode */
3086-
fsp_free_seg_inode(space, inode, true, mtr);
3084+
fsp_free_seg_inode(space, inode, mtr);
30873085

30883086
DBUG_RETURN(TRUE);
30893087
}
@@ -3097,7 +3095,7 @@ fseg_free_step_func(
30973095

30983096
if (n == ULINT_UNDEFINED) {
30993097
/* Freeing completed: free the segment inode */
3100-
fsp_free_seg_inode(space, inode, true, mtr);
3098+
fsp_free_seg_inode(space, inode, mtr);
31013099

31023100
DBUG_RETURN(TRUE);
31033101
}

0 commit comments

Comments
 (0)