Skip to content

Commit 722f1b2

Browse files
committed
Move the deprecated comments out of the way
1 parent 8d1f8e8 commit 722f1b2

File tree

1 file changed

+25
-21
lines changed

1 file changed

+25
-21
lines changed

sql/sql_window.cc

Lines changed: 25 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1440,22 +1440,10 @@ bool compute_two_pass_window_functions(Item_window_func *item_win,
14401440
return is_error;
14411441
}
14421442

1443-
1444-
/*
1445-
@brief
1446-
This function is called by JOIN::exec to compute window function values
1447-
1448-
@detail
1449-
JOIN::exec calls this after it has filled the temporary table with query
1450-
output. The temporary table has fields to store window function values.
1451-
1452-
@return
1453-
false OK
1454-
true Error
1455-
*/
1456-
1457-
bool JOIN::process_window_functions(List<Item> *curr_fields_list)
1458-
{
1443+
/////////////////////////////////////////////////////////////////////////////
1444+
// Unneeded comments (will be removed when we develop a replacement for
1445+
// the feature that was attempted here
1446+
/////////////////////////////////////////////////////////////////////////////
14591447
/*
14601448
TODO Get this code to set can_compute_window_function during preparation,
14611449
not during execution.
@@ -1491,14 +1479,10 @@ bool JOIN::process_window_functions(List<Item> *curr_fields_list)
14911479
prefixes, or be a prefix itself. This must hold true for all partitions.
14921480
Analog for the order by clause.
14931481
*/
1494-
1482+
#if 0
14951483
List<Item_window_func> window_functions;
14961484
SQL_I_List<ORDER> largest_partition;
14971485
SQL_I_List<ORDER> largest_order_by;
1498-
List_iterator_fast<Item> it(*curr_fields_list);
1499-
Item *item;
1500-
1501-
#if 0
15021486
bool can_compute_window_live = !need_tmp;
15031487
// Construct the window_functions item list and check if they can be
15041488
// computed using only one sorting.
@@ -1580,6 +1564,26 @@ bool JOIN::process_window_functions(List<Item> *curr_fields_list)
15801564
}
15811565
else
15821566
#endif
1567+
1568+
1569+
/*
1570+
@brief
1571+
This function is called by JOIN::exec to compute window function values
1572+
1573+
@detail
1574+
JOIN::exec calls this after it has filled the temporary table with query
1575+
output. The temporary table has fields to store window function values.
1576+
1577+
@return
1578+
false OK
1579+
true Error
1580+
*/
1581+
1582+
bool JOIN::process_window_functions(List<Item> *curr_fields_list)
1583+
{
1584+
List_iterator_fast<Item> it(*curr_fields_list);
1585+
Item *item;
1586+
15831587
{
15841588
while ((item= it++))
15851589
{

0 commit comments

Comments
 (0)