Skip to content

Commit 74d52de

Browse files
committed
fix binlog_encryption.binlog_incident test
1 parent 76546a0 commit 74d52de

File tree

6 files changed

+4
-15
lines changed

6 files changed

+4
-15
lines changed
File renamed without changes.

mysql-test/extra/rpl_tests/multisource.inc

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -4,20 +4,11 @@
44
# Please check all dependent tests after modifying it
55
#
66
# Usage:
7-
# --let $binlog_extra_length= X # optional, default 0
87
# --source extra/rpl_tests/multisource.inc
98
#
109
# By default, the script expects the length of the 2nd binary log to be
1110
# $binlog_start_pos + length(Gtid_list event) + 2 x length(Binlog_checkpoint event)
1211
# Some tests can have specific configuration which would change it,
13-
# e.g. for encrypted binlogs there will be additional event
14-
# Start_encryption of the length of 36.
15-
# binlog_extra_length should compensate for the difference.
16-
17-
if (!$binlog_extra_length)
18-
{
19-
--let $binlog_extra_length= 0
20-
}
2112

2213
#
2314
# Test basic replication functionality
@@ -244,7 +235,7 @@ flush logs;
244235
--connection master1
245236
purge binary logs to 'master-bin.000002';
246237
# Additional events: 39 (Gtid_list) + 2 x 40 (Binlog_checkpoint) = 119
247-
let filesize=`select $binlog_start_pos+119+$binlog_extra_length`;
238+
let filesize=`select $binlog_start_pos+119`;
248239
--replace_result $filesize filesize
249240
show binary logs;
250241
insert into t1 (f1) values ('four');

mysql-test/include/binlog_start_pos.inc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@
2121
#
2222
##############################################################################
2323

24-
let $binlog_start_pos=249;
2524
--disable_query_log
26-
SET @binlog_start_pos=249;
25+
set @binlog_start_pos=249 + @@encrypt_binlog * 36;
2726
--enable_query_log
27+
let $binlog_start_pos=`select @binlog_start_pos`;
2828

mysql-test/suite/binlog_encryption/binlog_incident.result

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,4 @@ REPLACE INTO t1 VALUES (4);
1010
DROP TABLE t1;
1111
FLUSH LOGS;
1212
Contain RELOAD DATABASE
13-
0
13+
1

mysql-test/suite/binlog_encryption/binlog_row_annotate.result

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
#####################################################################################
99
show binlog events in 'master-bin.000001' from <start_pos>;
1010
Log_name Pos Event_type Server_id End_log_pos Info
11-
master-bin.000001 # Start_encryption 1 #
1211
master-bin.000001 # Gtid_list 1 # []
1312
master-bin.000001 # Binlog_checkpoint 1 # master-bin.000001
1413
master-bin.000001 # Gtid 1 # GTID 0-1-1
Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,2 @@
1-
binlog_incident : MDEV-11319 - mysqlbinlog crash or failure
21
encrypted_master_lost_key : MDEV-11323 - unspecified behavior for IO thread
32
rpl_checksum_cache : MDEV-11486 - sporadic failure in IO thread

0 commit comments

Comments
 (0)