MDEV-34348: MariaDB is violating clang-16 -Wcast-function-type-strict

bnestere · bnestere · commit 773cb726a843 · 2024-11-23T08:14:23.000-07:00
This HEAD commit just makes cast-function-type-strict fatal.
It will stay at the HEAD, and prior commits contain the
actual fixes, organized by the part of the code that the fix
targets. Future changes will be force pushed to have their
fixes come before this HEAD.

This branch cherry-picks patches from daniel@mariadb.org
(in bb-10.5-MDEV-34508-ubsan-errors) which initially
incorporate the flag into the build, as well as fix some of
its findings.
diff --git a/cmake/maintainer.cmake b/cmake/maintainer.cmake
@@ -39,12 +39,12 @@ SET(MY_WARNING_FLAGS
   -Wsuggest-override
   -Wvla
   -Wwrite-strings
+  -Wcast-function-type-strict
   )
 
 # Warning flags that are in testing before moving
 # to MY_WARNING_FLAGS if stable.
 SET(MY_WARNING_FLAGS_NON_FATAL
-  cast-function-type-strict
   )
 
 FOREACH(F ${MY_WARNING_FLAGS})

Original file line number	Diff line number	Diff line change
`@@ -39,12 +39,12 @@ SET(MY_WARNING_FLAGS`
`39`	`39`	`-Wsuggest-override`
`40`	`40`	`-Wvla`
`41`	`41`	`-Wwrite-strings`
	`42`	`+ -Wcast-function-type-strict`
`42`	`43`	`)`
`43`	`44`
`44`	`45`	`# Warning flags that are in testing before moving`
`45`	`46`	`# to MY_WARNING_FLAGS if stable.`
`46`	`47`	`SET(MY_WARNING_FLAGS_NON_FATAL`
`47`		`- cast-function-type-strict`
`48`	`48`	`)`
`49`	`49`
`50`	`50`	`FOREACH(F ${MY_WARNING_FLAGS})`