Fix USE_AFTER_FREE (CWE-672)

FaramosCZ · svoj · commit 8be02be08bf6 · 2019-03-22T02:32:47.000+04:00
The file will be closed on line 540
diff --git a/sql/wsrep_binlog.cc b/sql/wsrep_binlog.cc
@@ -506,7 +506,6 @@ void wsrep_dump_rbr_buf_with_header(THD *thd, const void *rbr_buf,
 
   if (init_io_cache(&cache, file, 0, WRITE_CACHE, 0, 0, MYF(MY_WME | MY_NABP)))
   {
-    mysql_file_close(file, MYF(MY_WME));
     goto cleanup2;
   }
 

Original file line number	Diff line number	Diff line change
`@@ -506,7 +506,6 @@ void wsrep_dump_rbr_buf_with_header(THD thd, const void rbr_buf,`
`506`	`506`
`507`	`507`	`if (init_io_cache(&cache, file, 0, WRITE_CACHE, 0, 0, MYF(MY_WME \| MY_NABP)))`
`508`	`508`	`{`
`509`		`- mysql_file_close(file, MYF(MY_WME));`
`510`	`509`	`goto cleanup2;`
`511`	`510`	`}`
`512`	`511`