MDEV-21444 : Fix socket leak if AcceptEx() return WSAECONNRESET.

vaintroub · vaintroub · commit 983163209d02 · 2020-01-08T16:53:09.000+01:00
Also, ignore/retry on ERROR_NETNAME_DELETED in addition to WSAECONNRESET. This is how golang handles failing AcceptEx(), see golang/go@c7ef348
diff --git a/sql/handle_connections_win.cc b/sql/handle_connections_win.cc
@@ -207,10 +207,11 @@ retry :
       &m_overlapped);
 
     DWORD last_error=  ret? 0: WSAGetLastError();
-    if (last_error == WSAECONNRESET)
+    if (last_error == WSAECONNRESET || last_error == ERROR_NETNAME_DELETED)
     {
       if (m_tp_io)
         CancelThreadpoolIo(m_tp_io);
+      closesocket(m_client_socket);
       goto retry;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -207,10 +207,11 @@ retry :`
`207`	`207`	`&m_overlapped);`
`208`	`208`
`209`	`209`	`DWORD last_error= ret? 0: WSAGetLastError();`
`210`		`- if (last_error == WSAECONNRESET)`
	`210`	`+ if (last_error == WSAECONNRESET \|\| last_error == ERROR_NETNAME_DELETED)`
`211`	`211`	`{`
`212`	`212`	`if (m_tp_io)`
`213`	`213`	`CancelThreadpoolIo(m_tp_io);`
	`214`	`+ closesocket(m_client_socket);`
`214`	`215`	`goto retry;`
`215`	`216`	`}`
`216`	`217`