MDEV-36234: Add innodb_linux_aio

This controls which linux implementation to use for
innodb_use_native_aio=ON.

innodb_linux_aio=auto is equivalent to innodb_linux_aio=io_uring when
it is available, and falling back to innodb_linux_aio=aio when not.

Debian packaging is no longer aio exclusive or uring, so
for those older Debian or Ubuntu releases, its a remove_uring directive.
For more recent releases, add mandatory liburing for consistent packaging.

WITH_LIBAIO is now an independent option from WITH_URING.

LINUX_NATIVE_AIO preprocessor constant is renamed to HAVE_LIBAIO,
analogous to existing HAVE_URING.

tpool::is_aio_supported(): A common feature check.

is_linux_native_aio_supported(): Remove. This had originally been added in
mysql/mysql-server@0da310b in 2012
to fix an issue where io_submit() on CentOS 5.5 would return EINVAL
for a /tmp/#sql*.ibd file associated with CREATE TEMPORARY TABLE.
But, starting with commit 2e814d4 InnoDB
temporary tables will be written to innodb_temp_data_file_path.
The 2012 commit said that the error could occur on "old kernels".
Any GNU/Linux distribution that we currently support should be based
on a newer Linux kernel; for example, Red Hat Enterprise Linux 7
was released in 2014.

tpool::create_linux_aio(): Wraps the Linux implementations:
create_libaio() and create_liburing(), each defined in separate
compilation units (aio_linux.cc, aio_libaio.cc, aio_liburing.cc).

The CMake definitions are simplified using target_sources() and
target_compile_definitions(), all available since CMake 2.8.12.
With this change, there is no need to include ${CMAKE_SOURCE_DIR}/tpool
or add TPOOL_DEFINES flags anymore, target_link_libraries(lib tpool)
does all that.

This is joint work with Daniel Black and Vladislav Vaintroub.

Author: dr-m

cmake/plugin.cmake

@@ -161,6 +161,9 @@ MACRO(MYSQL_ADD_PLUGIN)
             PROPERTIES COMPILE_DEFINITIONS "EMBEDDED_LIBRARY${version_string}")
         ENDIF()
         ADD_DEPENDENCIES(${target}_embedded GenError ${ARG_DEPENDS})
+        IF(ARG_LINK_LIBRARIES)
+          TARGET_LINK_LIBRARIES (${target}_embedded ${ARG_LINK_LIBRARIES})
+        ENDIF()
       ENDIF()
     ENDIF()
 

debian/autobake-deb.sh

@@ -64,11 +64,10 @@ add_lsb_base_depends()
   sed -e 's#lsof #lsb-base (>= 3.0-10),\n         lsof #' -i debian/control
 }
 
-replace_uring_with_aio()
+remove_uring()
 {
-  sed 's/liburing-dev/libaio-dev/g' -i debian/control
-  sed -e '/-DIGNORE_AIO_CHECK=ON/d' \
-      -e '/-DWITH_URING=ON/d' -i debian/rules
+  sed -e '/liburing-dev/d' -i debian/control
+  sed -e '/-DWITH_URING=ON/d' -i debian/rules
 }
 
 disable_libfmt()
@@ -116,7 +115,7 @@ in
   # Debian
   "buster")
     disable_libfmt
-    replace_uring_with_aio
+    remove_uring
     ;&
   "bullseye")
     add_lsb_base_depends
@@ -127,7 +126,7 @@ in
     # so no removal is necessary.
     if [[ ! "$architecture" =~ amd64|arm64|armel|armhf|i386|mips64el|mipsel|ppc64el|s390x ]]
     then
-      replace_uring_with_aio
+      remove_uring
     fi
     ;&
   "trixie"|"sid")
@@ -136,8 +135,8 @@ in
     ;;
   # Ubuntu
   "focal")
-    replace_uring_with_aio
     disable_libfmt
+    remove_uring
     ;&
   "jammy"|"kinetic")
     add_lsb_base_depends

debian/rules

@@ -87,9 +87,6 @@ endif
 	# quality standards in Debian. Also building it requires an extra 4 GB of disk
 	# space which makes native Debian builds fail as the total disk space needed
 	# for MariaDB becomes over 10 GB. Only build CS via autobake-deb.sh.
-	#
-	# Note: Don't use '-DWITH_URING=ON' as some Buildbot builders are missing it
-	# and would fail permanently.
 	PATH=$${MYSQL_BUILD_PATH:-"/usr/lib/ccache:/usr/local/bin:/usr/bin:/bin"} \
 	    dh_auto_configure --builddirectory=$(BUILDDIR) -- \
 	    -DCMAKE_BUILD_TYPE=RelWithDebInfo \
@@ -103,6 +100,8 @@ endif
 	    -DPLUGIN_AWS_KEY_MANAGEMENT=NO \
 	    -DPLUGIN_COLUMNSTORE=NO \
 	    -DIGNORE_AIO_CHECK=ON \
+	    -DWITH_URING=ON \
+	    -DWITH_LIBAIO=ON \
 	    -DDEB=$(DEB_VENDOR)
 
 # This is needed, otherwise 'make test' will run before binaries have been built

extra/mariabackup/CMakeLists.txt

@@ -107,6 +107,8 @@ MYSQL_ADD_EXECUTABLE(mbstream
 TARGET_LINK_LIBRARIES(mbstream
   mysys
 )
+
+TARGET_INCLUDE_DIRECTORIES(mbstream PRIVATE ${PROJECT_SOURCE_DIR}/tpool)
 ADD_DEPENDENCIES(mbstream GenError)
 
 IF(MSVC)

extra/mariabackup/xtrabackup.cc

@@ -378,6 +378,10 @@ extern const char *innodb_checksum_algorithm_names[];
 extern TYPELIB innodb_checksum_algorithm_typelib;
 extern const char *innodb_flush_method_names[];
 extern TYPELIB innodb_flush_method_typelib;
+#ifdef __linux__
+extern const char *innodb_linux_aio_names[];
+extern TYPELIB innodb_linux_aio_typelib;
+#endif
 
 static const char *binlog_info_values[] = {"off", "lockless", "on", "auto",
 					   NullS};
@@ -1334,6 +1338,9 @@ enum options_xtrabackup
   OPT_INNODB_READ_IO_THREADS,
   OPT_INNODB_WRITE_IO_THREADS,
   OPT_INNODB_USE_NATIVE_AIO,
+#ifdef __linux__
+  OPT_INNODB_LINUX_AIO,
+#endif
   OPT_INNODB_PAGE_SIZE,
   OPT_INNODB_BUFFER_POOL_FILENAME,
   OPT_INNODB_LOCK_WAIT_TIMEOUT,
@@ -1934,6 +1941,14 @@ struct my_option xb_server_options[] =
    (G_PTR*) &srv_use_native_aio,
    (G_PTR*) &srv_use_native_aio, 0, GET_BOOL, NO_ARG,
    TRUE, 0, 0, 0, 0, 0},
+#ifdef __linux__
+  {"innodb_linux_aio", OPT_INNODB_LINUX_AIO,
+   "Which linux AIO implementation to use, auto (io_uring, failing to aio) or explicit",
+   (G_PTR*) &srv_linux_aio_method,
+   (G_PTR*) &srv_linux_aio_method,
+   &innodb_linux_aio_typelib, GET_ENUM, REQUIRED_ARG,
+   SRV_LINUX_AIO_AUTO, 0, 0, 0, 0, 0},
+#endif
   {"innodb_page_size", OPT_INNODB_PAGE_SIZE,
    "The universal page size of the database.",
    (G_PTR*) &innobase_page_size, (G_PTR*) &innobase_page_size, 0,
@@ -2529,26 +2544,7 @@ static bool innodb_init_param()
 
 	ut_ad(DATA_MYSQL_BINARY_CHARSET_COLL == my_charset_bin.number);
 
-#ifdef _WIN32
-	srv_use_native_aio = TRUE;
-
-#elif defined(LINUX_NATIVE_AIO)
-
-	if (srv_use_native_aio) {
-		msg("InnoDB: Using Linux native AIO");
-	}
-#elif defined(HAVE_URING)
-
-	if (srv_use_native_aio) {
-		msg("InnoDB: Using liburing");
-	}
-#else
-	/* Currently native AIO is supported only on windows and linux
-	and that also when the support is compiled in. In all other
-	cases, we ignore the setting of innodb_use_native_aio. */
-	srv_use_native_aio = FALSE;
-
-#endif
+	srv_use_native_aio= tpool::supports_native_aio();
 
 	/* Assign the default value to srv_undo_dir if it's not specified, as
 	my_getopt does not support default values for string options. We also
@@ -2583,9 +2579,6 @@ static bool innodb_init_param()
 		}
 	}
 
-#ifdef _WIN32
-	srv_use_native_aio = TRUE;
-#endif
 	return false;
 
 error:
@@ -5473,7 +5466,6 @@ static bool xtrabackup_backup_func()
 	xb_fil_io_init();
 
 	if (os_aio_init()) {
-		msg("Error: cannot initialize AIO subsystem");
 		goto fail;
 	}
 

libmysqld/CMakeLists.txt

@@ -21,7 +21,6 @@ INCLUDE_DIRECTORIES(
 ${CMAKE_SOURCE_DIR}/include 
 ${CMAKE_SOURCE_DIR}/libmysqld
 ${CMAKE_SOURCE_DIR}/sql
-${CMAKE_SOURCE_DIR}/tpool
 ${CMAKE_BINARY_DIR}/sql 
 ${PCRE_INCLUDE_DIRS}
 ${LIBFMT_INCLUDE_DIR}

mysql-test/mariadb-test-run.pl

@@ -4548,7 +4548,7 @@ ($$)
      qr|InnoDB: io_setup\(\) attempt|,
      qr|InnoDB: io_setup\(\) failed with EAGAIN|,
      qr|io_uring_queue_init\(\) failed with|,
-     qr|InnoDB: liburing disabled|,
+     qr|InnoDB: io_uring failed: falling back to libaio|,
      qr/InnoDB: Failed to set O_DIRECT on file/,
      qr|setrlimit could not change the size of core files to 'infinity';|,
      qr|failed to retrieve the MAC address|,

mysql-test/suite/sys_vars/r/innodb_linux_aio_basic.result

@@ -0,0 +1,21 @@
+select @@global.innodb_linux_aio;
+@@global.innodb_linux_aio
+auto
+select @@session.innodb_linux_aio;
+ERROR HY000: Variable 'innodb_linux_aio' is a GLOBAL variable
+show global variables like 'innodb_linux_aio';
+Variable_name	Value
+innodb_linux_aio	auto
+show session variables like 'innodb_linux_aio';
+Variable_name	Value
+innodb_linux_aio	auto
+select * from information_schema.global_variables where variable_name='innodb_linux_aio';
+VARIABLE_NAME	VARIABLE_VALUE
+INNODB_LINUX_AIO	auto
+select * from information_schema.session_variables where variable_name='innodb_linux_aio';
+VARIABLE_NAME	VARIABLE_VALUE
+INNODB_LINUX_AIO	auto
+set global innodb_linux_aio='auto';
+ERROR HY000: Variable 'innodb_linux_aio' is a read only variable
+set session innodb_linux_aio='aio';
+ERROR HY000: Variable 'innodb_linux_aio' is a read only variable

mysql-test/suite/sys_vars/r/sysvars_innodb.result

@@ -5,6 +5,7 @@ variable_name not in (
 'innodb_evict_tables_on_commit_debug', # one may want to override this
 'innodb_use_native_aio',            # default value depends on OS
 'innodb_log_file_buffering',        # only available on Linux and Windows
+'innodb_linux_aio',                 # existence depends on OS
 'innodb_buffer_pool_load_pages_abort')            # debug build only, and is only for testing
 order by variable_name;
 VARIABLE_NAME	INNODB_ADAPTIVE_FLUSHING

mysql-test/suite/sys_vars/t/innodb_linux_aio_basic.test

@@ -0,0 +1,23 @@
+--source include/have_innodb.inc
+--source include/linux.inc
+# enum readonly
+
+#
+# show values;
+#
+select @@global.innodb_linux_aio;
+--error ER_INCORRECT_GLOBAL_LOCAL_VAR
+select @@session.innodb_linux_aio;
+show global variables like 'innodb_linux_aio';
+show session variables like 'innodb_linux_aio';
+select * from information_schema.global_variables where variable_name='innodb_linux_aio';
+select * from information_schema.session_variables where variable_name='innodb_linux_aio';
+
+#
+# show that it's read-only
+#
+--error ER_INCORRECT_GLOBAL_LOCAL_VAR
+set global innodb_linux_aio='auto';
+--error ER_INCORRECT_GLOBAL_LOCAL_VAR
+set session innodb_linux_aio='aio';
+