Skip to content

Commit

Permalink
MDEV-9363 - Mroonga tests with datetime field fail on Solaris in buil…
Browse files Browse the repository at this point in the history
…dbot

On Solaris mktime() adds one extra day to tm_mday field and returns appropriate
value for dates 1600-01-01 and earlier. That is 1600-01-01 becomes 1600-01-02.

Solaris mktime manual excerpts:
  ...
  The tm_year member must be for year 1901 or later.  Calendar
  times  before  20:45:52  UTC,  December  13,  1901  or after
  03:14:07 UTC,  January 19, 2038 cannot be represented. Port-
  able  applications  should  not  try  to create dates before
  00:00:00 UTC, January 1, 1970 or after 00:00:00 UTC, January
  1, 2038.
  ...
  The  mktime() function assumes Gregorian dates. Times before
  the  adoption  of the Gregorian calendar will not match his-
  torial records.
  ...

According to manual Mroonga only supports dates and datetimes after 1900:
https://mariadb.com/kb/en/mariadb/about-mroonga/

Technically these tests cover unsupported values and should fail on all
platforms. Disable tests until the problem is fixed upstream.
  • Loading branch information
svoj committed Jul 8, 2016
1 parent ecb27d2 commit ae511cb
Show file tree
Hide file tree
Showing 8 changed files with 10 additions and 0 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
if (`SELECT @@version_compile_os='solaris10'`) {
skip This test is not for Solaris 10;
}
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@

--source ../../include/mroonga/skip_freebsd.inc
--source ../../include/mroonga/skip_osx.inc
--source ../../include/mroonga/skip_solaris10.inc
--source ../../include/mroonga/have_64bit.inc
--source ../../include/mroonga/have_mroonga.inc

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

--source ../../include/mroonga/skip_freebsd.inc
--source ../../include/mroonga/skip_osx.inc
--source ../../include/mroonga/skip_solaris10.inc
--source ../../include/mroonga/have_64bit.inc
--source ../../include/mroonga/have_mroonga.inc

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

--source ../../include/mroonga/skip_freebsd.inc
--source ../../include/mroonga/skip_osx.inc
--source ../../include/mroonga/skip_solaris10.inc
--source ../../include/mroonga/have_64bit.inc
--source ../../include/mroonga/have_mroonga.inc

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

--source ../../include/mroonga/skip_freebsd.inc
--source ../../include/mroonga/skip_osx.inc
--source ../../include/mroonga/skip_solaris10.inc
--source ../../include/mroonga/have_64bit.inc
--source ../../include/mroonga/have_mroonga.inc

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
--source ../../include/mroonga/have_64bit.inc
--source ../../include/mroonga/skip_freebsd.inc
--source ../../include/mroonga/skip_osx.inc
--source ../../include/mroonga/skip_solaris10.inc
--source ../../include/mroonga/have_mroonga.inc

--disable_warnings
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

--source ../../include/mroonga/skip_freebsd.inc
--source ../../include/mroonga/skip_osx.inc
--source ../../include/mroonga/skip_solaris10.inc
--source ../../include/mroonga/have_64bit.inc
--source ../../include/mroonga/have_mroonga.inc

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

--source ../../include/mroonga/skip_freebsd.inc
--source ../../include/mroonga/skip_osx.inc
--source ../../include/mroonga/skip_solaris10.inc
--source ../../include/mroonga/have_64bit.inc
--source ../../include/mroonga/have_mroonga.inc

Expand Down

0 comments on commit ae511cb

Please sign in to comment.