Skip to content

Commit b138414

Browse files
committed
fix many rpl test failures
* wait_until_connected_again.inc should expect ER_CONNECTION_KILLED now * also fix MySQL BUG#36228
1 parent ddc481b commit b138414

10 files changed

+12
-19
lines changed

libmariadb

mysql-test/extra/rpl_tests/rpl_get_master_version_and_clock.test

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,9 +61,8 @@ connection slave;
6161
# '2003' CR_CONN_HOST_ERROR
6262
# '2002' CR_CONNECTION_ERROR
6363
# '2006' CR_SERVER_GONE_ERROR
64-
# '1040' ER_CON_COUNT_ERROR
6564
# '1053' ER_SERVER_SHUTDOWN
66-
let $slave_io_errno= 1040, 1053, 2002, 2003, 2006, 2013;
65+
let $slave_io_errno= 1053, 2002, 2003, 2006, 2013;
6766
--let $slave_io_error_is_nonfatal= 1
6867
source include/wait_for_slave_io_error.inc;
6968

mysql-test/include/wait_for_slave_io_error.inc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
# $slave_io_errno
1919
# The expected IO error numbers. This can be either a single
2020
# number, or a comma-separated list of numbers. Examples:
21-
# --let $slave_io_errno= 1040, 1053, 2002, 2003, 2006, 2013
21+
# --let $slave_io_errno= 1053, 2002, 2003, 2006, 2013
2222
# --let $slave_io_errno= 1045
2323
# (After BUG#41956 has been fixed, this will be required to be
2424
# symbolic names instead of numbers.)

mysql-test/include/wait_until_connected_again.inc

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,7 @@ let $counter= 5000;
1111
let $mysql_errno= 9999;
1212
while ($mysql_errno)
1313
{
14-
# Strangely enough, the server might return "Too many connections"
15-
# while being shutdown, thus 1040 is an "allowed" error
16-
# See BUG#36228
17-
--error 0,1040,1053,2002,2003,2005,2006,2013
14+
--error 0,ER_SERVER_SHUTDOWN,ER_CONNECTION_KILLED,2002,2006,2013
1815
show status;
1916

2017
dec $counter;

mysql-test/include/wait_until_disconnected.inc

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,7 @@ let $counter= 600;
99
let $mysql_errno= 0;
1010
while (!$mysql_errno)
1111
{
12-
# Strangely enough, the server might return "Too many connections"
13-
# while being shutdown, thus 1040 is an "allowed" error.
14-
# See BUG#36228.
15-
--error 0,1040,1053,2002,2003,2005,2006,2013
12+
--error 0,ER_SERVER_SHUTDOWN,ER_CONNECTION_KILLED,2002,2006,2013
1613
show status;
1714

1815
dec $counter;

mysql-test/suite/innodb/t/innodb_sys_semaphore_waits.test

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,10 +77,10 @@ let $counter= 80;
7777
let $mysql_errno= 0;
7878
while (!$mysql_errno)
7979
{
80-
--error 0,1040,1053,2002,2003,2006,2013
80+
--error 0,ER_SERVER_SHUTDOWN,ER_CONNECTION_KILLED,2002,2006,2013
8181
show status;
8282

83-
--error 0,1040,1053,2002,2003,2006,2013
83+
--error 0,ER_SERVER_SHUTDOWN,ER_CONNECTION_KILLED,2002,2006,2013
8484
select * from information_schema.innodb_sys_semaphore_waits;
8585

8686
dec $counter;

mysql-test/suite/rpl/r/rpl_get_master_version_and_clock.result

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ include/rpl_stop_server.inc [server_number=1]
1212
slave is unblocked
1313
SET DEBUG_SYNC='now SIGNAL signal.get_unix_timestamp';
1414
Check network error happened here
15-
include/wait_for_slave_io_error.inc [errno=1040, 1053, 2002, 2003, 2006, 2013]
15+
include/wait_for_slave_io_error.inc [errno=1053, 2002, 2003, 2006, 2013]
1616
set @@global.debug = "-d,'debug_lock.before_get_UNIX_TIMESTAMP'";
1717
include/rpl_start_server.inc [server_number=1]
1818
include/wait_for_slave_param.inc [Slave_IO_Running]
@@ -24,7 +24,7 @@ include/rpl_stop_server.inc [server_number=1]
2424
slave is unblocked
2525
SET DEBUG_SYNC='now SIGNAL signal.get_server_id';
2626
Check network error happened here
27-
include/wait_for_slave_io_error.inc [errno=1040, 1053, 2002, 2003, 2006, 2013]
27+
include/wait_for_slave_io_error.inc [errno=1053, 2002, 2003, 2006, 2013]
2828
set @@global.debug = "-d,'debug_lock.before_get_SERVER_ID'";
2929
include/rpl_start_server.inc [server_number=1]
3030
include/wait_for_slave_param.inc [Slave_IO_Running]

mysql-test/suite/sys_vars/t/innodb_fatal_semaphore_wait_threshold.test

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ let $counter= 80;
8282
let $mysql_errno= 0;
8383
while (!$mysql_errno)
8484
{
85-
--error 0,1040,1053,2002,2003,2006,2013
85+
--error 0,ER_SERVER_SHUTDOWN,ER_CONNECTION_KILLED,2002,2006,2013
8686
show status;
8787

8888
dec $counter;

mysql-test/t/ipv4_as_ipv6.test

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ echo =============Test of '::1' ========================;
5252
let $IPv6= ::1;
5353
--echo connect (con1, $IPv6, root, , test, MASTER_MYPORT,);
5454
--disable_query_log
55-
--error 2003,2006
55+
--error 2002,2006
5656
connect (con1, $IPv6, root, , test, $MASTER_MYPORT,);
5757
--enable_query_log
5858

sql/mysqld.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6455,7 +6455,7 @@ static void create_new_thread(CONNECT *connect)
64556455
mysql_mutex_unlock(&LOCK_connection_count);
64566456
statistic_increment(denied_connections, &LOCK_status);
64576457
statistic_increment(connection_errors_max_connection, &LOCK_status);
6458-
connect->close_with_error(0, NullS, ER_CON_COUNT_ERROR);
6458+
connect->close_with_error(0, NullS, abort_loop ? ER_SERVER_SHUTDOWN : ER_CON_COUNT_ERROR);
64596459
DBUG_VOID_RETURN;
64606460
}
64616461

0 commit comments

Comments
 (0)