Skip to content

Commit b6e826b

Browse files
committed
MDEV-10118 : do not suggest upgrade from MySQL 5.7 to MariaDB 10.x in the installer. Do not lauch upgrade wizard after installation
1 parent cee9ab9 commit b6e826b

File tree

2 files changed

+12
-5
lines changed

2 files changed

+12
-5
lines changed

sql/winservice.c

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -81,8 +81,10 @@ void normalize_path(char *path, size_t size)
8181
and services. We do not want to mess up with these installations. We will
8282
just ignore such services, pretending it is not MySQL.
8383
84-
´@return
85-
TRUE, if this service should be excluded from UI lists etc (OEM install)
84+
We also exclude MySQL5.7+ since we cannot upgrade it (and it is not an upgrade anyway)
85+
86+
@return
87+
TRUE, if this service should be excluded from UI lists etc
8688
FALSE otherwise.
8789
*/
8890
BOOL exclude_service(mysqld_service_properties *props)
@@ -104,7 +106,12 @@ BOOL exclude_service(mysqld_service_properties *props)
104106
if (strstr(buf, exclude_patterns[i]))
105107
return TRUE;
106108
}
107-
109+
if ((props->version_major == 0) ||
110+
(props->version_major > 5 && props->version_major < 10) ||
111+
(props->version_major == 5 && props->version_minor > 6))
112+
{
113+
return TRUE;
114+
}
108115
return FALSE;
109116
}
110117

win/packaging/ca/CustomAction.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -886,11 +886,11 @@ extern "C" UINT __stdcall CheckServiceUpgrades(MSIHANDLE hInstall)
886886
(QUERY_SERVICE_CONFIGW*)(void *)config_buffer;
887887
DWORD needed;
888888
BOOL ok= QueryServiceConfigW(service, config,sizeof(config_buffer),
889-
&needed);
889+
&needed) && (config->dwStartType != SERVICE_DISABLED);
890890
CloseServiceHandle(service);
891891
if (ok)
892892
{
893-
mysqld_service_properties props;
893+
mysqld_service_properties props;
894894
if (get_mysql_service_properties(config->lpBinaryPathName, &props))
895895
continue;
896896
/*

0 commit comments

Comments
 (0)