|
1 | 1 | <!--
|
2 | 2 | Thank you for contributing to the MariaDB Server repository!
|
3 | 3 |
|
4 |
| -You can help us review your changes faster by filling this template <3 |
| 4 | +You can help us review your changes faster by filling in this template <3 |
5 | 5 |
|
6 |
| -If you have any questions related to MariaDB or you just want to |
7 |
| -hang out and meet other community members, please join us on |
8 |
| -https://mariadb.zulipchat.com/ . |
| 6 | +If you have any questions related to MariaDB or you just want to hang out and meet other community members, please join us on https://mariadb.zulipchat.com/ . |
9 | 7 | -->
|
10 | 8 |
|
11 | 9 | <!--
|
12 |
| -If you've already identified a https://jira.mariadb.org/ issue |
13 |
| -that seems to track this bug/feature, please add its number below. |
| 10 | +If you've already identified a https://jira.mariadb.org/ issue that seems to track this bug/feature, please add its number below. |
14 | 11 | -->
|
15 |
| -- [x] *The Jira issue number for this PR is: MDEV-_____* |
| 12 | +- [x] *The Jira issue number for this PR is: MDEV-______* |
16 | 13 |
|
17 | 14 | <!--
|
18 | 15 | An amazing description should answer some questions like:
|
19 | 16 | 1. What problem is the patch trying to solve?
|
20 |
| -2. If some output changed, what was it looking like before |
21 |
| - the change and how it's looking with this patch applied |
22 |
| -3. Do you think this patch might introduce side-effects in |
23 |
| - other parts of the server? |
| 17 | +2. If some output changed that is not visible in a test case, what was it looking like before the change and how it's looking with this patch applied? |
| 18 | +3. Do you think this patch might introduce side-effects in other parts of the server? |
24 | 19 | -->
|
25 | 20 | ## Description
|
26 | 21 | TODO: fill description here
|
27 | 22 |
|
28 | 23 | ## How can this PR be tested?
|
29 | 24 |
|
30 |
| -TODO: modify the automated test suite to verify that the PR causes MariaDB to |
31 |
| -behave as intended. Consult the documentation on |
32 |
| -["Writing good test cases"](https://mariadb.org/get-involved/getting-started-for-developers/writing-good-test-cases-mariadb-server). |
33 |
| -In many cases, this will be as simple as modifying one `.test` and one `.result` |
34 |
| -file in the `mysql-test/` subdirectory. Without _automated_ tests, future regressions |
35 |
| -in the expected behavior can't be automatically detected and verified. |
| 25 | +TODO: modify the automated test suite to verify that the PR causes MariaDB to behave as intended. |
| 26 | +Consult the documentation on ["Writing good test cases"](https://mariadb.org/get-involved/getting-started-for-developers/writing-good-test-cases-mariadb-server). |
| 27 | +<!-- |
| 28 | +In many cases, this will be as simple as modifying one `.test` and one `.result` file in the `mysql-test/` subdirectory. |
| 29 | +Without automated tests, future regressions in the expected behavior can't be automatically detected and verified. |
| 30 | +--> |
36 | 31 |
|
37 |
| -If the changes are not amenable to automated testing, please explain why not and |
38 |
| -carefully describe how to test manually. |
| 32 | +If the changes are not amenable to automated testing, please explain why not and carefully describe how to test manually. |
39 | 33 |
|
40 | 34 | <!--
|
41 |
| -Tick one of the following boxes [x] to help us understand |
42 |
| -if the base branch for the PR is correct |
43 |
| -(Currently the earliest maintained branch is 10.3) |
| 35 | +Tick one of the following boxes [x] to help us understand if the base branch for the PR is correct. (Currently the earliest maintained branch is 10.3) |
44 | 36 | -->
|
45 | 37 | ## Basing the PR against the correct MariaDB version
|
46 |
| -- [ ] *This is a new feature and the PR is based against the latest MariaDB development branch* |
47 |
| -- [ ] *This is a bug fix and the PR is based against the earliest maintained branch in which the bug can be reproduced* |
| 38 | +- [ ] *This is a new feature and the PR is based against the latest MariaDB development branch.* |
| 39 | +- [ ] *This is a bug fix and the PR is based against the earliest maintained branch in which the bug can be reproduced.* |
48 | 40 |
|
49 | 41 | <!--
|
50 |
| -You might consider answering some questions like: |
51 |
| -1. Does this affect the on-disk format used by MariaDB? |
52 |
| -2. Does this change any behavior experienced by a user |
53 |
| - who upgrades from a version prior to this patch? |
54 |
| -3. Would a user be able to start MariaDB on a datadir |
55 |
| - created prior to your fix? |
| 42 | + All code merged into the MariaDB codebase must meet a quality standard and codying style. |
| 43 | + Maintainers are happy to point out inconsistencies but in order to speed up the review and merge process we ask you to check the CODING standards. |
56 | 44 | -->
|
57 |
| -## Backward compatibility |
58 |
| -TODO: fill details here, if applicable, or remove the section |
59 |
| - |
60 | 45 | ## PR quality check
|
61 | 46 | - [ ] I checked the [CODING_STANDARDS.md](https://github.com/MariaDB/server/blob/11.0/CODING_STANDARDS.md) file and my PR conforms to this where appropriate.
|
| 47 | +- [ ] For any trivial modifications to the PR, I am ok with the reviewer making the changes themselves. |
0 commit comments