MDEV-26826 fixup for Valgrind and MemorySanitizer

dr-m · dr-m · commit ba4f8e317de3 · 2021-11-09T09:38:12.000+02:00
The debug assertion that was added in commit 9b967c4 tripped Valgrind and MemorySanitizer. buf_block_init(): Assert that block->page.hash was zero-initialized.
diff --git a/storage/innobase/buf/buf0buf.cc b/storage/innobase/buf/buf0buf.cc
@@ -993,6 +993,8 @@ buf_block_init(buf_block_t* block, byte* frame)
 
 	page_zip_des_init(&block->page.zip);
 
+	MEM_MAKE_DEFINED(&block->page.hash, sizeof block->page.hash);
+	ut_ad(!block->page.hash);
 	MEM_MAKE_DEFINED(&block->lock, sizeof block->lock);
 	block->lock.init();
 }

Original file line number	Diff line number	Diff line change
`@@ -993,6 +993,8 @@ buf_block_init(buf_block_t* block, byte* frame)`
`993`	`993`
`994`	`994`	`page_zip_des_init(&block->page.zip);`
`995`	`995`
	`996`	`+ MEM_MAKE_DEFINED(&block->page.hash, sizeof block->page.hash);`
	`997`	`+ ut_ad(!block->page.hash);`
`996`	`998`	`MEM_MAKE_DEFINED(&block->lock, sizeof block->lock);`
`997`	`999`	`block->lock.init();`
`998`	`1000`	`}`