Skip to content

Commit c64a697

Browse files
author
Alexey Botchkov
committed
MDEV-13921 Audit log writes invalid SQL if single-line comments are
present. thread_pool_server_audit.test fixed. plugin version updated.
1 parent 2e964b2 commit c64a697

File tree

3 files changed

+11
-5
lines changed

3 files changed

+11
-5
lines changed

mysql-test/suite/plugins/r/thread_pool_server_audit.result

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ alter table t1 rename renamed_t1;
4747
set global server_audit_events='connect,query';
4848
select 1,
4949
2,
50+
# comment
5051
3;
5152
1 2 3
5253
1 2 3
@@ -161,7 +162,9 @@ id
161162
2
162163
CREATE USER u1 IDENTIFIED BY 'pwd-123';
163164
GRANT ALL ON sa_db TO u2 IDENTIFIED BY "pwd-321";
164-
SET PASSWORD FOR u1 = PASSWORD('pwd 098');
165+
SET PASSWORD
166+
# comment
167+
FOR u1 = PASSWORD('pwd 098');
165168
SET PASSWORD FOR u1=<secret>;
166169
ERROR 42000: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near '<secret>' at line 1
167170
CREATE USER u3 IDENTIFIED BY '';
@@ -251,7 +254,7 @@ TIME,HOSTNAME,root,localhost,ID,ID,ALTER,test,t1,
251254
TIME,HOSTNAME,root,localhost,ID,ID,RENAME,test,t1|test.renamed_t1,
252255
TIME,HOSTNAME,root,localhost,ID,ID,QUERY,test,'alter table t1 rename renamed_t1',0
253256
TIME,HOSTNAME,root,localhost,ID,ID,QUERY,test,'set global server_audit_events=\'connect,query\'',0
254-
TIME,HOSTNAME,root,localhost,ID,ID,QUERY,test,'select 1, 2, 3',0
257+
TIME,HOSTNAME,root,localhost,ID,ID,QUERY,test,'select 1,\n2,\n# comment\n3',0
255258
TIME,HOSTNAME,root,localhost,ID,ID,QUERY,test,'insert into t2 values (1), (2)',0
256259
TIME,HOSTNAME,root,localhost,ID,ID,QUERY,test,'select * from t2',0
257260
TIME,HOSTNAME,root,localhost,ID,ID,QUERY,test,'select * from t_doesnt_exist',ID
@@ -325,7 +328,7 @@ TIME,HOSTNAME,root,localhost,ID,ID,QUERY,sa_db,'/*! select 2*/',0
325328
TIME,HOSTNAME,root,localhost,ID,ID,QUERY,sa_db,'/*comment*/ select 2',0
326329
TIME,HOSTNAME,root,localhost,ID,ID,QUERY,sa_db,'CREATE USER u1 IDENTIFIED BY *****',0
327330
TIME,HOSTNAME,root,localhost,ID,ID,QUERY,sa_db,'GRANT ALL ON sa_db TO u2 IDENTIFIED BY *****',0
328-
TIME,HOSTNAME,root,localhost,ID,ID,QUERY,sa_db,'SET PASSWORD FOR u1 = PASSWORD(*****)',0
331+
TIME,HOSTNAME,root,localhost,ID,ID,QUERY,sa_db,'SET PASSWORD\n# comment\nFOR u1 = PASSWORD(*****)',0
329332
TIME,HOSTNAME,root,localhost,ID,ID,QUERY,sa_db,'SET PASSWORD FOR u1=<secret>',ID
330333
TIME,HOSTNAME,root,localhost,ID,ID,QUERY,sa_db,'CREATE USER u3 IDENTIFIED BY *****',0
331334
TIME,HOSTNAME,root,localhost,ID,ID,QUERY,sa_db,'drop user u1, u2, u3',0

mysql-test/suite/plugins/t/thread_pool_server_audit.test

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ alter table t1 rename renamed_t1;
3838
set global server_audit_events='connect,query';
3939
select 1,
4040
2,
41+
# comment
4142
3;
4243
insert into t2 values (1), (2);
4344
select * from t2;
@@ -106,7 +107,9 @@ insert into t1 values (1), (2);
106107
select * from t1;
107108
CREATE USER u1 IDENTIFIED BY 'pwd-123';
108109
GRANT ALL ON sa_db TO u2 IDENTIFIED BY "pwd-321";
109-
SET PASSWORD FOR u1 = PASSWORD('pwd 098');
110+
SET PASSWORD
111+
# comment
112+
FOR u1 = PASSWORD('pwd 098');
110113
--error 1064
111114
SET PASSWORD FOR u1=<secret>;
112115
CREATE USER u3 IDENTIFIED BY '';

plugin/server_audit/server_audit.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515

1616

1717
#define PLUGIN_VERSION 0x104
18-
#define PLUGIN_STR_VERSION "1.4.2"
18+
#define PLUGIN_STR_VERSION "1.4.3"
1919

2020
#define _my_thread_var loc_thread_var
2121

0 commit comments

Comments
 (0)