MDEV-35494 fixup: Always initialize latch

dr-m · dr-m · commit c982a143fccd · 2024-12-16T13:23:13.000+02:00
It turns out that init() always checks in debug builds that
some fields of the latch had been filled with zero.
diff --git a/storage/innobase/fil/fil0fil.cc b/storage/innobase/fil/fil0fil.cc
@@ -938,9 +938,7 @@ fil_space_t::fil_space_t(uint32_t id, ulint flags, bool being_imported,
   id(id), crypt_data(crypt_data), being_imported(being_imported), flags(flags)
 {
   UT_LIST_INIT(chain, &fil_node_t::chain);
-#ifndef SUX_LOCK_GENERIC
   memset((void*) &latch, 0, sizeof latch);
-#endif
   latch.SRW_LOCK_INIT(fil_space_latch_key);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -938,9 +938,7 @@ fil_space_t::fil_space_t(uint32_t id, ulint flags, bool being_imported,`
`938`	`938`	`id(id), crypt_data(crypt_data), being_imported(being_imported), flags(flags)`
`939`	`939`	`{`
`940`	`940`	`UT_LIST_INIT(chain, &fil_node_t::chain);`
`941`		`-#ifndef SUX_LOCK_GENERIC`
`942`	`941`	`memset((void*) &latch, 0, sizeof latch);`
`943`		`-#endif`
`944`	`942`	`latch.SRW_LOCK_INIT(fil_space_latch_key);`
`945`	`943`	`}`
`946`	`944`