Skip to content

Commit cfaab61

Browse files
janlindstromsysprg
authored andcommitted
MDEV-24481 : galera_3nodes.galera_vote_rejoin_mysqldump MTR failed: mysql_shutdown failed
Improve test case to wait until cluster membership is correct. Signed-off-by: Julius Goryavsky <julius.goryavsky@mariadb.com>
1 parent 2b8c59f commit cfaab61

File tree

3 files changed

+16
-18
lines changed

3 files changed

+16
-18
lines changed

mysql-test/suite/galera_3nodes/disabled.def

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212

1313
galera_2_cluster : MDEV-32631 galera_2_cluster: before_rollback(): Assertion `0' failed
1414
galera_gtid_2_cluster : MDEV-32633 galera_gtid_2_cluster: Assertion `thd->wsrep_next_trx_id() != (0x7fffffffffffffffLL * 2ULL + 1)'
15-
galera_vote_rejoin_mysqldump : MDEV-24481: galera_3nodes.galera_vote_rejoin_mysqldump MTR failed: mysql_shutdown failed
1615
galera_ssl_reload : MDEV-32778 galera_ssl_reload failed with warning message
1716
galera_ipv6_mariabackup : temporarily disabled at the request of Codership
1817
galera_pc_bootstrap : temporarily disabled at the request of Codership

mysql-test/suite/galera_3nodes/r/galera_vote_rejoin_mysqldump.result

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,9 @@ SELECT VARIABLE_VALUE AS expect_Disconnected FROM INFORMATION_SCHEMA.GLOBAL_STAT
3939
expect_Disconnected
4040
Disconnected
4141
SET SESSION wsrep_on=ON;
42+
SELECT VARIABLE_VALUE AS expect_3 FROM INFORMATION_SCHEMA.GLOBAL_STATUS WHERE VARIABLE_NAME = 'wsrep_cluster_size';
43+
expect_3
44+
3
4245
SELECT VARIABLE_VALUE AS expect_Primary FROM INFORMATION_SCHEMA.GLOBAL_STATUS WHERE VARIABLE_NAME = 'wsrep_cluster_status';
4346
expect_Primary
4447
Primary
@@ -49,17 +52,11 @@ t1 CREATE TABLE `t1` (
4952
`f1` int(11) DEFAULT NULL
5053
) ENGINE=InnoDB DEFAULT CHARSET=latin1 COLLATE=latin1_swedish_ci
5154
connection node_2;
52-
SET SESSION wsrep_on=OFF;
53-
SET SESSION wsrep_on=ON;
54-
# restart
5555
SHOW CREATE TABLE t1;
5656
Table Create Table
5757
t1 CREATE TABLE `t1` (
5858
`f1` int(11) DEFAULT NULL
5959
) ENGINE=InnoDB DEFAULT CHARSET=latin1 COLLATE=latin1_swedish_ci
60-
SELECT COUNT(*) AS expect_0 FROM t1;
61-
expect_0
62-
0
6360
CALL mtr.add_suppression("is inconsistent with group");
6461
connection node_3;
6562
SHOW CREATE TABLE t1;
@@ -81,3 +78,6 @@ CALL mtr.add_suppression("Can't open and lock privilege tables");
8178
CALL mtr.add_suppression("Info table is not ready to be used");
8279
CALL mtr.add_suppression("Native table .* has the wrong structure");
8380
CALL mtr.add_suppression("Table \'mysql.gtid_slave_pos\' doesn\'t exist");
81+
connection node_2;
82+
# restart
83+
connection node_1;

mysql-test/suite/galera_3nodes/t/galera_vote_rejoin_mysqldump.test

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,7 @@ SET SESSION wsrep_on=ON;
5959
--let $wait_condition = SELECT VARIABLE_VALUE = 3 FROM INFORMATION_SCHEMA.GLOBAL_STATUS WHERE VARIABLE_NAME = 'wsrep_cluster_size';
6060
--source include/wait_condition.inc
6161

62+
SELECT VARIABLE_VALUE AS expect_3 FROM INFORMATION_SCHEMA.GLOBAL_STATUS WHERE VARIABLE_NAME = 'wsrep_cluster_size';
6263
SELECT VARIABLE_VALUE AS expect_Primary FROM INFORMATION_SCHEMA.GLOBAL_STATUS WHERE VARIABLE_NAME = 'wsrep_cluster_status';
6364

6465
# Confirm that the table is now identical throughout
@@ -67,18 +68,7 @@ SELECT VARIABLE_VALUE AS expect_Primary FROM INFORMATION_SCHEMA.GLOBAL_STATUS WH
6768
SHOW CREATE TABLE t1;
6869

6970
--connection node_2
70-
SET SESSION wsrep_on=OFF;
71-
--let $wait_condition = SELECT VARIABLE_VALUE = 'Primary' FROM INFORMATION_SCHEMA.GLOBAL_STATUS WHERE VARIABLE_NAME = 'wsrep_cluster_status';
72-
--source include/wait_condition.inc
73-
--source include/galera_wait_ready.inc
74-
SET SESSION wsrep_on=ON;
75-
76-
# restart node so we don't fail on WSREP_START_POSITION internal check
77-
--source include/restart_mysqld.inc
78-
--source include/wait_until_connected_again.inc
79-
8071
SHOW CREATE TABLE t1;
81-
SELECT COUNT(*) AS expect_0 FROM t1;
8272
CALL mtr.add_suppression("is inconsistent with group");
8373

8474
--connection node_3
@@ -89,5 +79,14 @@ CALL mtr.add_suppression("Slave SQL: Error 'Can't DROP 'PRIMARY'; check that col
8979
--connection node_1
9080
--source suite/galera/include/galera_sst_restore.inc
9181

82+
--connection node_2
83+
# restart node so we don't fail on WSREP_START_POSITION internal check
84+
--source include/restart_mysqld.inc
85+
--source include/wait_until_connected_again.inc
86+
87+
--connection node_1
88+
--let $wait_condition = SELECT VARIABLE_VALUE = 3 FROM INFORMATION_SCHEMA.GLOBAL_STATUS WHERE VARIABLE_NAME = 'wsrep_cluster_size';
89+
--source include/wait_condition.inc
90+
9291
# Restore original auto_increment_offset values.
9392
--source ../galera/include/auto_increment_offset_restore.inc

0 commit comments

Comments
 (0)