MDEV-30544 Deprecate innodb_defragment and related parameters

There is a little used option innodb_defragment that would make
OPTIMIZE TABLE not rebuild the table as usual for InnoDB, but
instead cause the index B-trees to be optimized in place.

This option uses excessive locking (exclusively locking index trees).
It never covered SPATIAL INDEX or FULLTEXT INDEX. Storage space
was never reclaimed.

Because this option is not particularly useful and causes a
maintenance burden (most recently in
commit de4030e),
it is best to deprecate it, to prepare for its removal.

Author: dr-m

mysql-test/main/lock_sync-master.opt

@@ -1,2 +1 @@
 --default-storage-engine=MyISAM
---innodb-defragment=0

mysql-test/suite/innodb/r/defrag_mdl-9155.result

@@ -1,4 +1,6 @@
 set global innodb_defragment=1;
+Warnings:
+Warning	1287	'@@innodb_defragment' is deprecated and will be removed in a future release
 create table t1 (a int not null primary key auto_increment, b varchar(256), key second(a, b)) engine=innodb;
 insert t1 select null, repeat('a', 256) from seq_1_to_100;
 select count(*) from t1;
@@ -16,3 +18,5 @@ test.t1	optimize	status	OK
 connection con1;
 drop table t1;
 set global innodb_defragment=default;
+Warnings:
+Warning	1287	'@@innodb_defragment' is deprecated and will be removed in a future release

mysql-test/suite/innodb/r/innodb_defrag_concurrent.result

@@ -3,6 +3,8 @@ SET @accuracy= @@GLOBAL.innodb_defragment_stats_accuracy;
 SET @sp= @@GLOBAL.innodb_stats_persistent;
 SET GLOBAL innodb_stats_persistent = 0;
 set global innodb_defragment_stats_accuracy = 80;
+Warnings:
+Warning	1287	'@@innodb_defragment_stats_accuracy' is deprecated and will be removed in a future release
 CREATE TABLE t1 (a INT NOT NULL PRIMARY KEY AUTO_INCREMENT,
 b VARCHAR(256),
 c INT,
@@ -18,6 +20,8 @@ connect  con3,localhost,root,,test,$MASTER_MYPORT,$MASTER_MYSOCK;
 connect  con4,localhost,root,,test,$MASTER_MYPORT,$MASTER_MYSOCK;
 connection default;
 SET @@global.innodb_defragment_n_pages = 20;
+Warnings:
+Warning	1287	'@@innodb_defragment_n_pages' is deprecated and will be removed in a future release
 CREATE TEMPORARY TABLE tt (a INT, KEY(a)) ENGINE=InnoDB ROW_FORMAT=REDUNDANT;
 INSERT INTO tt SELECT 0 FROM seq_1_to_180;
 INSERT INTO tt SELECT 5 FROM seq_1_to_160;
@@ -98,5 +102,9 @@ count(stat_value) > 0
 1
 drop table t1;
 SET GLOBAL innodb_defragment_n_pages = @n_pages;
+Warnings:
+Warning	1287	'@@innodb_defragment_n_pages' is deprecated and will be removed in a future release
 SET GLOBAL innodb_defragment_stats_accuracy = @accuracy;
+Warnings:
+Warning	1287	'@@innodb_defragment_stats_accuracy' is deprecated and will be removed in a future release
 SET GLOBAL innodb_stats_persistent = @sp;

mysql-test/suite/innodb/r/innodb_defrag_stats.result

@@ -1,4 +1,6 @@
 SET GLOBAL innodb_defragment_stats_accuracy = 20;
+Warnings:
+Warning	1287	'@@innodb_defragment_stats_accuracy' is deprecated and will be removed in a future release
 DELETE FROM mysql.innodb_index_stats;
 # Create table.
 CREATE TABLE t1 (a INT PRIMARY KEY AUTO_INCREMENT, b VARCHAR(256),
@@ -77,6 +79,8 @@ t1	SECOND	n_leaf_pages_reserved
 t1	SECOND	n_page_split
 t1	SECOND	n_pages_freed
 set global innodb_defragment_stats_accuracy = 40;
+Warnings:
+Warning	1287	'@@innodb_defragment_stats_accuracy' is deprecated and will be removed in a future release
 INSERT INTO t1 (b) SELECT b from t1;
 SELECT table_name, index_name, stat_name FROM mysql.innodb_index_stats;
 table_name	index_name	stat_name
@@ -116,6 +120,8 @@ drop index SECOND on t2;
 # MDEV-26636: Statistics must not be written for temporary tables
 #
 SET GLOBAL innodb_defragment_stats_accuracy = 1;
+Warnings:
+Warning	1287	'@@innodb_defragment_stats_accuracy' is deprecated and will be removed in a future release
 CREATE TEMPORARY TABLE t (a INT PRIMARY KEY, c CHAR(255) NOT NULL)
 ENGINE=InnoDB;
 INSERT INTO t SELECT seq, '' FROM seq_1_to_100;

mysql-test/suite/innodb/r/innodb_defrag_stats_many_tables.result

@@ -5,6 +5,8 @@ SET @start_flush_log_at_trx_commit = @@global.innodb_flush_log_at_trx_commit;
 SET @@global.innodb_flush_log_at_trx_commit=2;
 SET @start_innodb_defragment_stats_accuracy = @@global.innodb_defragment_stats_accuracy;
 SET @@global.innodb_defragment_stats_accuracy = 80;
+Warnings:
+Warning	1287	'@@innodb_defragment_stats_accuracy' is deprecated and will be removed in a future release
 CREATE TABLE t1 (a INT NOT NULL PRIMARY KEY AUTO_INCREMENT, b VARCHAR(256), KEY SECOND(a, b)) ENGINE=INNODB;
 INSERT INTO t1 VALUES(1, REPEAT('A', 256));
 INSERT INTO t1 (b) SELECT b from t1;
@@ -34,5 +36,7 @@ sleep(15)
 select stat_value > 0 from mysql.innodb_index_stats where table_name like '%t1%' and stat_name = 'n_page_split';
 stat_value > 0
 SET @@global.innodb_defragment_stats_accuracy = @start_innodb_defragment_stats_accuracy;
+Warnings:
+Warning	1287	'@@innodb_defragment_stats_accuracy' is deprecated and will be removed in a future release
 SET @@global.table_definition_cache = @start_table_definition_cache;
 DROP TABLE t1;

mysql-test/suite/innodb/r/innodb_defragment.result

@@ -1,4 +1,6 @@
 set global innodb_defragment_stats_accuracy = 80;
+Warnings:
+Warning	1287	'@@innodb_defragment_stats_accuracy' is deprecated and will be removed in a future release
 CREATE TABLE t1 (a INT NOT NULL PRIMARY KEY AUTO_INCREMENT, b VARCHAR(256), KEY SECOND(a, b)) ENGINE=INNODB;
 optimize table t1;
 Table	Op	Msg_type	Msg_text
@@ -66,6 +68,8 @@ select count(stat_value) = 0 from mysql.innodb_index_stats where table_name like
 count(stat_value) = 0
 1
 SET @@global.innodb_defragment_n_pages = 3;
+Warnings:
+Warning	1287	'@@innodb_defragment_n_pages' is deprecated and will be removed in a future release
 optimize table t1;
 Table	Op	Msg_type	Msg_text
 test.t1	optimize	status	OK
@@ -104,6 +108,8 @@ select count(stat_value) = 0 from mysql.innodb_index_stats where table_name like
 count(stat_value) = 0
 1
 SET @@global.innodb_defragment_n_pages = 10;
+Warnings:
+Warning	1287	'@@innodb_defragment_n_pages' is deprecated and will be removed in a future release
 optimize table t1;
 Table	Op	Msg_type	Msg_text
 test.t1	optimize	status	OK

mysql-test/suite/innodb/r/innodb_defragment_small.result

@@ -1,6 +1,8 @@
 SET @innodb_defragment_orig=@@GLOBAL.innodb_defragment;
 SET @innodb_optimize_fulltext_orig=@@GLOBAL.innodb_optimize_fulltext_only;
 SET GLOBAL innodb_defragment = 1;
+Warnings:
+Warning	1287	'@@innodb_defragment' is deprecated and will be removed in a future release
 SET GLOBAL innodb_optimize_fulltext_only = 0;
 #
 # MDEV-12198 innodb_defragment=1 crashes server on
@@ -27,6 +29,8 @@ OPTIMIZE TABLE t1;
 Table	Op	Msg_type	Msg_text
 test.t1	optimize	status	OK
 SET GLOBAL innodb_defragment = 0;
+Warnings:
+Warning	1287	'@@innodb_defragment' is deprecated and will be removed in a future release
 OPTIMIZE TABLE t1;
 Table	Op	Msg_type	Msg_text
 test.t1	optimize	status	OK
@@ -37,4 +41,6 @@ Table	Op	Msg_type	Msg_text
 test.t1	optimize	status	OK
 DROP TABLE t1;
 SET GLOBAL innodb_defragment = @innodb_defragment_orig;
+Warnings:
+Warning	1287	'@@innodb_defragment' is deprecated and will be removed in a future release
 SET GLOBAL innodb_optimize_fulltext_only = @innodb_optimize_fulltext_orig;

mysql-test/suite/innodb/r/instant_alter_debug.result

@@ -279,10 +279,14 @@ SET GLOBAL innodb_limit_optimistic_insert_debug = @old_limit;
 ALTER TABLE t1 ADD COLUMN b INT, ALGORITHM=INSTANT;
 SET @old_defragment = @@innodb_defragment;
 SET GLOBAL innodb_defragment = 1;
+Warnings:
+Warning	1287	'@@innodb_defragment' is deprecated and will be removed in a future release
 OPTIMIZE TABLE t1;
 Table	Op	Msg_type	Msg_text
 test.t1	optimize	status	OK
 SET GLOBAL innodb_defragment = @old_defragment;
+Warnings:
+Warning	1287	'@@innodb_defragment' is deprecated and will be removed in a future release
 ALTER TABLE t1 ADD vb INT AS (b) VIRTUAL;
 CHECK TABLE t1;
 Table	Op	Msg_type	Msg_text

mysql-test/suite/innodb/t/innodb.opt

@@ -3,10 +3,14 @@ SELECT @orig;
 @orig
 0
 SET GLOBAL innodb_defragment = OFF;
+Warnings:
+Warning	1287	'@@innodb_defragment' is deprecated and will be removed in a future release
 SELECT @@global.innodb_defragment;
 @@global.innodb_defragment
 0
 SET GLOBAL innodb_defragment = ON;
+Warnings:
+Warning	1287	'@@innodb_defragment' is deprecated and will be removed in a future release
 SELECT @@global.innodb_defragment;
 @@global.innodb_defragment
 1
@@ -16,3 +20,5 @@ SELECT @@global.innodb_defragment;
 @@global.innodb_defragment
 1
 SET GLOBAL innodb_defragment = @orig;
+Warnings:
+Warning	1287	'@@innodb_defragment' is deprecated and will be removed in a future release