Skip to content

Commit db20137

Browse files
abarkovabarkov
committed
MDEV-23570 deprecate keep_files_on_create
1 parent 93756c9 commit db20137

File tree

4 files changed

+129
-1
lines changed

4 files changed

+129
-1
lines changed

‎mysql-test/main/set_statement.result

Lines changed: 74 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,8 @@ sort_buffer_size 100000
132132
'#------------------ STATEMENT Test 6 -----------------------#'
133133
'# Initialize variables to known setting'
134134
SET SESSION keep_files_on_create=ON;
135+
Warnings:
136+
Warning 1287 '@@keep_files_on_create' is deprecated and will be removed in a future release
135137
''
136138
'# Pre-STATEMENT variable value'
137139
SHOW SESSION VARIABLES LIKE 'keep_files_on_create';
@@ -142,6 +144,9 @@ SET STATEMENT keep_files_on_create=OFF FOR SELECT *,@@keep_files_on_create FROM
142144
v1 v2 @@keep_files_on_create
143145
1 2 0
144146
3 4 0
147+
Warnings:
148+
Warning 1287 '@@keep_files_on_create' is deprecated and will be removed in a future release
149+
Warning 1287 '@@keep_files_on_create' is deprecated and will be removed in a future release
145150
''
146151
'# Post-STATEMENT variable value'
147152
SHOW SESSION VARIABLES LIKE 'keep_files_on_create';
@@ -174,6 +179,8 @@ myisam_repair_threads=1,
174179
sort_buffer_size = 200000,
175180
max_join_size=2222220000000,
176181
keep_files_on_create=ON;
182+
Warnings:
183+
Warning 1287 '@@keep_files_on_create' is deprecated and will be removed in a future release
177184
''
178185
'# LONG '
179186
SHOW SESSION VARIABLES LIKE 'sort_buffer_size';
@@ -195,6 +202,9 @@ SET STATEMENT keep_files_on_create=OFF
195202
FOR SHOW SESSION VARIABLES LIKE 'keep_files_on_create';
196203
Variable_name Value
197204
keep_files_on_create OFF
205+
Warnings:
206+
Warning 1287 '@@keep_files_on_create' is deprecated and will be removed in a future release
207+
Warning 1287 '@@keep_files_on_create' is deprecated and will be removed in a future release
198208
SHOW SESSION VARIABLES LIKE 'keep_files_on_create';
199209
Variable_name Value
200210
keep_files_on_create ON
@@ -231,6 +241,8 @@ sort_buffer_size=100000,
231241
binlog_format=mixed,
232242
keep_files_on_create=ON,
233243
max_join_size=2222220000000;
244+
Warnings:
245+
Warning 1287 '@@keep_files_on_create' is deprecated and will be removed in a future release
234246
''
235247
''
236248
'# Pre-STATEMENT variable value
@@ -263,6 +275,9 @@ max_join_size=4444440000000 FOR
263275
SELECT myProc(123.45);
264276
myProc(123.45)
265277
200006.17
278+
Warnings:
279+
Warning 1287 '@@keep_files_on_create' is deprecated and will be removed in a future release
280+
Warning 1287 '@@keep_files_on_create' is deprecated and will be removed in a future release
266281
SET STATEMENT myisam_sort_buffer_size=400000,
267282
myisam_repair_threads=2,
268283
sort_buffer_size=300000,
@@ -272,6 +287,9 @@ max_join_size=4444440000000 FOR
272287
SELECT myProc(123.45);
273288
myProc(123.45)
274289
300006.17
290+
Warnings:
291+
Warning 1287 '@@keep_files_on_create' is deprecated and will be removed in a future release
292+
Warning 1287 '@@keep_files_on_create' is deprecated and will be removed in a future release
275293
''
276294
'# Post-STATEMENT No 1 variable value Pre-STATEMENT for No 2'
277295
SELECT @@myisam_sort_buffer_size,
@@ -290,6 +308,9 @@ binlog_format=row,
290308
keep_files_on_create=OFF,
291309
max_join_size=4444440000000 FOR
292310
DROP FUNCTION myProc;
311+
Warnings:
312+
Warning 1287 '@@keep_files_on_create' is deprecated and will be removed in a future release
313+
Warning 1287 '@@keep_files_on_create' is deprecated and will be removed in a future release
293314
''
294315
'# Post-STATEMENT No 2 variable value
295316
SELECT @@myisam_sort_buffer_size,
@@ -309,6 +330,8 @@ sort_buffer_size=100000,
309330
binlog_format=mixed,
310331
keep_files_on_create=ON,
311332
max_join_size=2222220000000;
333+
Warnings:
334+
Warning 1287 '@@keep_files_on_create' is deprecated and will be removed in a future release
312335
''
313336
''
314337
'# Pre-STATEMENT variable value
@@ -329,6 +352,9 @@ keep_files_on_create=OFF,
329352
max_join_size=4444440000000 FOR
330353
PREPARE stmt1 FROM
331354
'SET STATEMENT binlog_format=row FOR SELECT *,@@binlog_format,@@sort_buffer_size FROM t1';
355+
Warnings:
356+
Warning 1287 '@@keep_files_on_create' is deprecated and will be removed in a future release
357+
Warning 1287 '@@keep_files_on_create' is deprecated and will be removed in a future release
332358
''
333359
'Test No 1 Post Value & Test 2 Pre values'
334360
SELECT @@myisam_sort_buffer_size,
@@ -350,6 +376,9 @@ EXECUTE stmt1;
350376
v1 v2 @@binlog_format @@sort_buffer_size
351377
1 2 ROW 200000
352378
3 4 ROW 200000
379+
Warnings:
380+
Warning 1287 '@@keep_files_on_create' is deprecated and will be removed in a future release
381+
Warning 1287 '@@keep_files_on_create' is deprecated and will be removed in a future release
353382
''
354383
'# Post-STATEMENT No 2
355384
SELECT @@myisam_sort_buffer_size,
@@ -370,6 +399,8 @@ sort_buffer_size=100000,
370399
binlog_format=mixed,
371400
keep_files_on_create=ON,
372401
max_join_size=2222220000000;
402+
Warnings:
403+
Warning 1287 '@@keep_files_on_create' is deprecated and will be removed in a future release
373404
''
374405
''
375406
'# Pre-STATEMENT variable value
@@ -397,6 +428,9 @@ SELECT @@myisam_sort_buffer_size,
397428
@@keep_files_on_create,
398429
@@max_join_size;
399430
END|
431+
Warnings:
432+
Warning 1287 '@@keep_files_on_create' is deprecated and will be removed in a future release
433+
Warning 1287 '@@keep_files_on_create' is deprecated and will be removed in a future release
400434
''
401435
'Test No 1 Post Value & Test 2 Pre values'
402436
SELECT @@myisam_sort_buffer_size,
@@ -418,6 +452,9 @@ max_join_size=4444440000001 FOR
418452
CALL p1();
419453
@@myisam_sort_buffer_size @@myisam_repair_threads @@sort_buffer_size @@binlog_format @@keep_files_on_create @@max_join_size
420454
400001 3 200001 ROW 0 4444440000001
455+
Warnings:
456+
Warning 1287 '@@keep_files_on_create' is deprecated and will be removed in a future release
457+
Warning 1287 '@@keep_files_on_create' is deprecated and will be removed in a future release
421458
''
422459
'# Post-STATEMENT No 2
423460
SELECT @@myisam_sort_buffer_size,
@@ -438,6 +475,8 @@ sort_buffer_size=100000,
438475
binlog_format=mixed,
439476
keep_files_on_create=ON,
440477
max_join_size=2222220000000;
478+
Warnings:
479+
Warning 1287 '@@keep_files_on_create' is deprecated and will be removed in a future release
441480
''
442481
''
443482
CREATE PROCEDURE p2() BEGIN
@@ -470,6 +509,11 @@ max_join_size=4444440000000 FOR
470509
CALL p2();
471510
@@myisam_sort_buffer_size @@myisam_repair_threads @@sort_buffer_size @@binlog_format @@keep_files_on_create @@max_join_size
472511
400000 3 300000 MIXED 0 3333330000000
512+
Warnings:
513+
Warning 1287 '@@keep_files_on_create' is deprecated and will be removed in a future release
514+
Warning 1287 '@@keep_files_on_create' is deprecated and will be removed in a future release
515+
Warning 1287 '@@keep_files_on_create' is deprecated and will be removed in a future release
516+
Warning 1287 '@@keep_files_on_create' is deprecated and will be removed in a future release
473517
''
474518
'# Post-STATEMENT
475519
SELECT @@myisam_sort_buffer_size,
@@ -490,6 +534,8 @@ sort_buffer_size=100000,
490534
binlog_format=mixed,
491535
keep_files_on_create=ON,
492536
max_join_size=2222220000000;
537+
Warnings:
538+
Warning 1287 '@@keep_files_on_create' is deprecated and will be removed in a future release
493539
''
494540
''
495541
CREATE PROCEDURE p3() BEGIN
@@ -530,6 +576,13 @@ CALL p3();
530576
400000 2 200000 ROW 0 4444440000000
531577
@@myisam_sort_buffer_size @@myisam_repair_threads @@sort_buffer_size @@binlog_format @@keep_files_on_create @@max_join_size
532578
400000 3 300000 MIXED 0 3333330000000
579+
Warnings:
580+
Warning 1287 '@@keep_files_on_create' is deprecated and will be removed in a future release
581+
Warning 1287 '@@keep_files_on_create' is deprecated and will be removed in a future release
582+
Warning 1287 '@@keep_files_on_create' is deprecated and will be removed in a future release
583+
Warning 1287 '@@keep_files_on_create' is deprecated and will be removed in a future release
584+
Warning 1287 '@@keep_files_on_create' is deprecated and will be removed in a future release
585+
Warning 1287 '@@keep_files_on_create' is deprecated and will be removed in a future release
533586
''
534587
'# Post-STATEMENT
535588
SELECT @@myisam_sort_buffer_size,
@@ -552,6 +605,8 @@ sort_buffer_size=100000,
552605
binlog_format=mixed,
553606
keep_files_on_create=ON,
554607
max_join_size=2222220000000;
608+
Warnings:
609+
Warning 1287 '@@keep_files_on_create' is deprecated and will be removed in a future release
555610
''
556611
''
557612
CREATE PROCEDURE p4() BEGIN
@@ -625,6 +680,11 @@ CALL p4();
625680
320000 2 220022 ROW 1 2222220000000
626681
@@myisam_sort_buffer_size @@myisam_repair_threads @@sort_buffer_size @@binlog_format @@keep_files_on_create @@max_join_size
627682
320000 2 220022 ROW 1 2222220000000
683+
Warnings:
684+
Warning 1287 '@@keep_files_on_create' is deprecated and will be removed in a future release
685+
Warning 1287 '@@keep_files_on_create' is deprecated and will be removed in a future release
686+
Warning 1287 '@@keep_files_on_create' is deprecated and will be removed in a future release
687+
Warning 1287 '@@keep_files_on_create' is deprecated and will be removed in a future release
628688
''
629689
'# Post-STATEMENT
630690
SELECT @@myisam_sort_buffer_size,
@@ -768,6 +828,8 @@ sort_buffer_size=100000,
768828
binlog_format=mixed,
769829
keep_files_on_create=ON,
770830
max_join_size=2222220000000;
831+
Warnings:
832+
Warning 1287 '@@keep_files_on_create' is deprecated and will be removed in a future release
771833
''
772834
'# Pre-STATEMENT variable value
773835
SELECT @@myisam_sort_buffer_size,
@@ -793,6 +855,10 @@ sort_buffer_size=230013,
793855
binlog_format=row,
794856
keep_files_on_create=ON,
795857
max_join_size=2323230000000;
858+
Warnings:
859+
Warning 1287 '@@keep_files_on_create' is deprecated and will be removed in a future release
860+
Warning 1287 '@@keep_files_on_create' is deprecated and will be removed in a future release
861+
Warning 1287 '@@keep_files_on_create' is deprecated and will be removed in a future release
796862
''
797863
'# Post-STATEMENT
798864
SELECT @@myisam_sort_buffer_size,
@@ -813,6 +879,8 @@ sort_buffer_size=100000,
813879
binlog_format=mixed,
814880
keep_files_on_create=ON,
815881
max_join_size=2222220000000;
882+
Warnings:
883+
Warning 1287 '@@keep_files_on_create' is deprecated and will be removed in a future release
816884
''
817885
'# Pre-STATEMENT variable value
818886
SELECT @@myisam_sort_buffer_size,
@@ -859,6 +927,10 @@ CALL p5();
859927
400000 2 200000 ROW 0 4444440000000
860928
@@myisam_sort_buffer_size @@myisam_repair_threads @@sort_buffer_size @@binlog_format @@keep_files_on_create @@max_join_size
861929
260000 3 230013 ROW 1 2323230000000
930+
Warnings:
931+
Warning 1287 '@@keep_files_on_create' is deprecated and will be removed in a future release
932+
Warning 1287 '@@keep_files_on_create' is deprecated and will be removed in a future release
933+
Warning 1287 '@@keep_files_on_create' is deprecated and will be removed in a future release
862934
''
863935
'# Post-STATEMENT
864936
SELECT @@myisam_sort_buffer_size,
@@ -970,6 +1042,8 @@ SELECT @@binlog_format;
9701042
ROW
9711043
SET @@binlog_format = @save_binlog_format;
9721044
SET @@keep_files_on_create = @save_keep_files_on_create;
1045+
Warnings:
1046+
Warning 1287 '@@keep_files_on_create' is deprecated and will be removed in a future release
9731047
SET @@max_join_size = @save_max_join_size;
9741048
SET @@myisam_repair_threads = @save_myisam_repair_threads;
9751049
SET @@myisam_sort_buffer_size = @save_myisam_sort_buffer_size;

‎mysql-test/main/symlink.result

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -157,9 +157,13 @@ a
157157
drop table t1;
158158
End of 4.1 tests
159159
SET SESSION keep_files_on_create = TRUE;
160+
Warnings:
161+
Warning 1287 '@@keep_files_on_create' is deprecated and will be removed in a future release
160162
CREATE TABLE t1 (a INT) ENGINE MYISAM;
161163
Got one of the listed errors
162164
SET SESSION keep_files_on_create = FALSE;
165+
Warnings:
166+
Warning 1287 '@@keep_files_on_create' is deprecated and will be removed in a future release
163167
CREATE TABLE t1 (a INT) ENGINE MYISAM;
164168
DROP TABLE t1;
165169
End of 5.0 tests

0 commit comments

Comments
 (0)