MDEV-35210 Vector type cannot store values which VEC_FromText produces and VEC_ToText accepts

let VEC_FromText validate that the vector l2squared isn't NaN.
VEC_ToText still prints everything.

Author: vuvova

mysql-test/main/vector_funcs.result

@@ -58,3 +58,9 @@ drop table t1;
 --echo # MDEV-35212 Server crashes in Item_func_vec_fromtext::val_str upon query from empty table
 --echo #
 select vec_fromtext(NULL);
+
+--echo #
+--echo # MDEV-35210 Vector type cannot store values which VEC_FromText produces and VEC_ToText accepts
+--echo #
+select vec_totext(0x77777777);
+select hex(vec_fromtext('[5.01922e33]'));

mysql-test/main/vector_funcs.test

@@ -22,6 +22,7 @@
 
 #include "item_vectorfunc.h"
 #include "vector_mhnsw.h"
+#include "sql_type_vector.h"
 
 key_map Item_func_vec_distance_common::part_of_sortkey() const
 {
@@ -191,18 +192,22 @@ String *Item_func_vec_fromtext::val_str(String *buf)
   if (!end_ok)
     goto error_format;
 
-  return buf;
+  if (Type_handler_vector::is_valid(buf->ptr(), buf->length()))
+    return buf;
+
+  null_value= true;
+  push_warning_printf(current_thd, Sql_condition::WARN_LEVEL_WARN,
+                      ER_TRUNCATED_WRONG_VALUE, ER(ER_TRUNCATED_WRONG_VALUE),
+                      "vector", value->ptr());
+  return nullptr;
 
 error_format:
   {
     int position= (int)((const char *) je.s.c_str - value->ptr());
     null_value= true;
-    THD *thd= current_thd;
-    push_warning_printf(thd, Sql_condition::WARN_LEVEL_WARN,
-                        ER_VECTOR_FORMAT_INVALID,
-                        ER_THD(thd, ER_VECTOR_FORMAT_INVALID),
-                        position,
-                        value->ptr());
+    push_warning_printf(current_thd, Sql_condition::WARN_LEVEL_WARN,
+                        ER_VECTOR_FORMAT_INVALID, ER(ER_VECTOR_FORMAT_INVALID),
+                        position, value->ptr());
     return nullptr;
   }
 

sql/item_vectorfunc.cc

@@ -311,13 +311,7 @@ int Field_vector::store(const char *from, size_t length, CHARSET_INFO *cs)
     if (length != field_length)
       return report_wrong_value(ErrConvString(from, length, cs));
 
-    float abs2= 0.0f;
-    for (const char *v= from, *end= from+length; v < end; v+= sizeof(float))
-    {
-      float val= get_float(v);
-      abs2+= val*val;
-    }
-    if (!std::isfinite(abs2))
+    if (!Type_handler_vector::is_valid(from, length))
       return report_wrong_value(ErrConvString(from, length, cs));
   }
 

sql/sql_type_vector.cc

@@ -87,6 +87,17 @@ class Type_handler_vector: public Type_handler_varchar
          override;
   bool Item_datetime_typecast_fix_length_and_dec(Item_datetime_typecast *) const
          override;
+
+  static bool is_valid(const char *from, size_t length)
+  {
+    float abs2= 0.0f;
+    for (const char *v= from, *end= from+length; v < end; v+= sizeof(float))
+    {
+      float val= get_float(v);
+      abs2+= val*val;
+    }
+    return std::isfinite(abs2);
+  }
 };
 
 extern Named_type_handler<Type_handler_vector> type_handler_vector;