Skip to content

Commit e16d91b

Browse files
author
Jan Lindström
committed
Fix merge error on tests.
1 parent d6ee7ab commit e16d91b

File tree

3 files changed

+82
-78
lines changed

3 files changed

+82
-78
lines changed

mysql-test/t/alter_table.test

Lines changed: 42 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -287,7 +287,7 @@ drop table t1;
287287
#
288288
set names koi8r;
289289
create table t1 (a char(10) character set koi8r);
290-
insert into t1 values ('����');
290+
insert into t1 values ('����');
291291
select a,hex(a) from t1;
292292
alter table t1 change a a char(10) character set cp1251;
293293
select a,hex(a) from t1;
@@ -367,7 +367,7 @@ DROP TABLE T12207;
367367
# modified. In other words, the values were reinterpreted
368368
# as UTF8 instead of being converted.
369369
create table t1 (a text) character set koi8r;
370-
insert into t1 values (_koi8r'����');
370+
insert into t1 values (_koi8r'����');
371371
select hex(a) from t1;
372372
alter table t1 convert to character set cp1251;
373373
select hex(a) from t1;
@@ -1346,52 +1346,55 @@ DROP TABLE t1, t2, t3;
13461346
SET SQL_MODE=default;
13471347
SET GLOBAL max_allowed_packet=default;
13481348

1349+
#
1350+
# Test of ALTER TABLE IF [NOT] EXISTS
1351+
#
13491352

1350-
SET GLOBAL max_allowed_packet=17825792;
1351-
1352-
--connect(con1, localhost, root,,)
1353-
CREATE TABLE t1 (t1_fld1 TEXT);
1354-
CREATE TABLE t2 (t2_fld1 MEDIUMTEXT);
1355-
CREATE TABLE t3 (t3_fld1 LONGTEXT);
1356-
1357-
INSERT INTO t1 VALUES (REPEAT('a',300));
1358-
INSERT INTO t2 VALUES (REPEAT('b',65680));
1359-
INSERT INTO t3 VALUES (REPEAT('c',16777300));
1353+
CREATE TABLE t1 (
1354+
id INT(11) NOT NULL,
1355+
x_param INT(11) DEFAULT NULL,
1356+
PRIMARY KEY (id)
1357+
) ENGINE=MYISAM;
13601358

1361-
SELECT LENGTH(t1_fld1) FROM t1;
1362-
SELECT LENGTH(t2_fld1) FROM t2;
1363-
SELECT LENGTH(t3_fld1) FROM t3;
1359+
ALTER TABLE t1 ADD COLUMN IF NOT EXISTS id INT,
1360+
ADD COLUMN IF NOT EXISTS lol INT AFTER id;
1361+
ALTER TABLE t1 ADD COLUMN IF NOT EXISTS lol INT AFTER id;
1362+
ALTER TABLE t1 DROP COLUMN IF EXISTS lol;
1363+
ALTER TABLE t1 DROP COLUMN IF EXISTS lol;
13641364

1365-
--echo # With strict mode
1366-
SET SQL_MODE='STRICT_ALL_TABLES';
1365+
ALTER TABLE t1 ADD KEY IF NOT EXISTS x_param(x_param);
1366+
ALTER TABLE t1 ADD KEY IF NOT EXISTS x_param(x_param);
1367+
ALTER TABLE t1 MODIFY IF EXISTS lol INT;
13671368

1368-
--error ER_DATA_TOO_LONG
1369-
ALTER TABLE t1 CHANGE `t1_fld1` `my_t1_fld1` TINYTEXT;
1370-
--error ER_DATA_TOO_LONG
1371-
ALTER TABLE t2 CHANGE `t2_fld1` `my_t2_fld1` TEXT;
1372-
--error ER_DATA_TOO_LONG
1373-
ALTER TABLE t3 CHANGE `t3_fld1` `my_t3_fld1` MEDIUMTEXT;
1374-
1375-
--echo # With non-strict mode
1376-
SET SQL_MODE='';
1369+
DROP INDEX IF EXISTS x_param ON t1;
1370+
DROP INDEX IF EXISTS x_param ON t1;
1371+
CREATE INDEX IF NOT EXISTS x_param1 ON t1(x_param);
1372+
CREATE INDEX IF NOT EXISTS x_param1 ON t1(x_param);
1373+
SHOW CREATE TABLE t1;
1374+
DROP TABLE t1;
13771375

1378-
ALTER TABLE t1 CHANGE `t1_fld1` `my_t1_fld1` TINYTEXT;
1379-
ALTER TABLE t2 CHANGE `t2_fld1` `my_t2_fld1` TEXT;
1380-
ALTER TABLE t3 CHANGE `t3_fld1` `my_t3_fld1` MEDIUMTEXT;
1376+
CREATE TABLE t1 (
1377+
id INT(11) NOT NULL,
1378+
x_param INT(11) DEFAULT NULL,
1379+
PRIMARY KEY (id)
1380+
) ENGINE=INNODB;
13811381

1382-
SELECT LENGTH(my_t1_fld1) FROM t1;
1383-
SELECT LENGTH(my_t2_fld1) FROM t2;
1384-
SELECT LENGTH(my_t3_fld1) FROM t3;
1382+
CREATE TABLE t2 (
1383+
id INT(11) NOT NULL) ENGINE=INNODB;
13851384

1386-
# Cleanup
1387-
--disconnect con1
1388-
--source include/wait_until_disconnected.inc
1385+
ALTER TABLE t1 ADD COLUMN IF NOT EXISTS id INT,
1386+
ADD COLUMN IF NOT EXISTS lol INT AFTER id;
1387+
ALTER TABLE t1 ADD COLUMN IF NOT EXISTS lol INT AFTER id;
1388+
ALTER TABLE t1 DROP COLUMN IF EXISTS lol;
1389+
ALTER TABLE t1 DROP COLUMN IF EXISTS lol;
13891390

1390-
--connection default
1391-
DROP TABLE t1, t2, t3;
1391+
ALTER TABLE t1 ADD KEY IF NOT EXISTS x_param(x_param);
1392+
ALTER TABLE t1 ADD KEY IF NOT EXISTS x_param(x_param);
1393+
ALTER TABLE t1 MODIFY IF EXISTS lol INT;
13921394

1393-
SET SQL_MODE=default;
1394-
SET GLOBAL max_allowed_packet=default;
1395+
DROP INDEX IF EXISTS x_param ON t1;
1396+
DROP INDEX IF EXISTS x_param ON t1;
1397+
CREATE INDEX IF NOT EXISTS x_param1 ON t1(x_param);
13951398
CREATE INDEX IF NOT EXISTS x_param1 ON t1(x_param);
13961399
SHOW CREATE TABLE t1;
13971400

mysql-test/t/grant.test

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -210,26 +210,26 @@ drop user mysqltest_1@localhost;
210210
# Bug#3403 Wrong encoding in SHOW GRANTS output
211211
#
212212
SET NAMES koi8r;
213-
CREATE DATABASE ��;
214-
USE ��;
215-
CREATE TABLE ��� (��� INT);
213+
CREATE DATABASE ��;
214+
USE ��;
215+
CREATE TABLE ��� (��� INT);
216216

217-
GRANT SELECT ON ��.* TO ����@localhost;
218-
SHOW GRANTS FOR ����@localhost;
219-
REVOKE SELECT ON ��.* FROM ����@localhost;
217+
GRANT SELECT ON ��.* TO ����@localhost;
218+
SHOW GRANTS FOR ����@localhost;
219+
REVOKE SELECT ON ��.* FROM ����@localhost;
220220

221-
GRANT SELECT ON ��.��� TO ����@localhost;
222-
SHOW GRANTS FOR ����@localhost;
223-
REVOKE SELECT ON ��.��� FROM ����@localhost;
221+
GRANT SELECT ON ��.��� TO ����@localhost;
222+
SHOW GRANTS FOR ����@localhost;
223+
REVOKE SELECT ON ��.��� FROM ����@localhost;
224224

225-
GRANT SELECT (���) ON ��.��� TO ����@localhost;
226-
SHOW GRANTS FOR ����@localhost;
227-
REVOKE SELECT (���) ON ��.��� FROM ����@localhost;
225+
GRANT SELECT (���) ON ��.��� TO ����@localhost;
226+
SHOW GRANTS FOR ����@localhost;
227+
REVOKE SELECT (���) ON ��.��� FROM ����@localhost;
228228

229229
# Revoke does not drop user. Leave a clean user table for the next tests.
230-
DROP USER ����@localhost;
230+
DROP USER ����@localhost;
231231

232-
DROP DATABASE ��;
232+
DROP DATABASE ��;
233233
SET NAMES latin1;
234234

235235
#
@@ -512,14 +512,14 @@ set @user123="non-existent";
512512
select * from mysql.db where user=@user123;
513513

514514
set names koi8r;
515-
create database ��;
516-
grant select on ��.* to root@localhost;
517-
select hex(Db) from mysql.db where Db='��';
515+
create database ��;
516+
grant select on ��.* to root@localhost;
517+
select hex(Db) from mysql.db where Db='��';
518518
show grants for root@localhost;
519519
flush privileges;
520520
show grants for root@localhost;
521-
drop database ��;
522-
revoke all privileges on ��.* from root@localhost;
521+
drop database ��;
522+
revoke all privileges on ��.* from root@localhost;
523523
show grants for root@localhost;
524524
set names latin1;
525525

mysql-test/t/type_float.test

Lines changed: 21 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -363,32 +363,33 @@ DROP TABLE t1;
363363

364364

365365
--echo #
366-
--echo # MDEV-17249 MAKETIME(-1e50,0,0) returns a wrong result
366+
--echo # Bug #13500371 63704: CONVERSION OF '1.' TO A NUMBER GIVES ERROR 1265
367+
--echo # (WARN_DATA_TRUNCATED)
367368
--echo #
368369

369-
SELECT LEFT('a',EXP(50));
370-
SELECT LEFT('a', COALESCE(1e30));
371-
372-
CREATE TABLE t1 (a FLOAT);
373-
INSERT INTO t1 VALUES (1e30);
374-
SELECT LEFT('a',a), LEFT('a',1e30) FROM t1;
370+
CREATE TABLE t1 (f FLOAT);
371+
INSERT INTO t1 VALUES ('1.');
372+
INSERT INTO t1 VALUES ('2.0.');
373+
INSERT INTO t1 VALUES ('.');
374+
SELECT * FROM t1 ORDER BY f;
375375
DROP TABLE t1;
376376

377-
PREPARE stmt FROM 'SELECT LEFT(111,?)';
378-
SET @a=1e30;
379-
EXECUTE stmt USING @a;
380-
DEALLOCATE PREPARE stmt;
381377

382-
CREATE TABLE t1 (a INT);
383-
INSERT INTO t1 VALUES (1),(2),(3);
384-
SELECT LEFT('a',(SELECT 1e30 FROM t1 LIMIT 1));
385-
DROP TABLE t1;
378+
--echo #
379+
--echo # Start of 10.0 tests
380+
--echo #
386381

387-
CREATE TABLE t1 (a DOUBLE);
388-
INSERT INTO t1 VALUES (1e30),(0);
389-
SELECT LEFT('a', SUM(a)) FROM t1;
390-
SELECT LEFT('a', AVG(a)) FROM t1;
391-
DROP TABLE t1;
382+
--echo #
383+
--echo # MDEV-6950 Bad results with joins comparing DATE/DATETIME and INT/DECIMAL/DOUBLE/ENUM/VARCHAR columns
384+
--echo #
385+
CREATE TABLE t1 (a DATETIME PRIMARY KEY);
386+
INSERT INTO t1 VALUES ('1999-01-01 00:00:00');
387+
CREATE TABLE t2 (a DOUBLE);
388+
INSERT INTO t2 VALUES (19990101000000);
389+
INSERT INTO t2 VALUES (990101000000);
390+
SELECT t1.* FROM t1,t2 WHERE t1.a=t2.a;
391+
SELECT t1.* FROM t1 LEFT JOIN t2 ON t1.a=t2.a;
392+
ALTER TABLE t2 ADD PRIMARY KEY(a);
392393
SELECT t1.* FROM t1,t2 WHERE t1.a=t2.a;
393394
SELECT t1.* FROM t1 LEFT JOIN t2 ON t1.a=t2.a;
394395
--echo # t2 should NOT be eliminated

0 commit comments

Comments
 (0)