Skip to content

Commit e7ddf46

Browse files
committed
MDEV-25211 Remove useless counter Innodb_buffered_aio_submitted
In commit 412533b (MDEV-18582), one of the counters that was ported from XtraDB is useless. Innodb_buffered_aio_submitted would be 0 or 1, depending on whether is_linux_native_aio_supported() was executed to the point where it would be incremented. Let us remove this counter, because it has no practical value. Even if its value were 1, io_setup() can still fail and we may end up with innodb_use_native_aio=0.
1 parent 8570a6a commit e7ddf46

File tree

3 files changed

+0
-8
lines changed

3 files changed

+0
-8
lines changed

storage/innobase/handler/ha_innodb.cc

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -866,9 +866,6 @@ static SHOW_VAR innodb_status_variables[]= {
866866
{"adaptive_hash_non_hash_searches", &btr_cur_n_non_sea, SHOW_SIZE_T},
867867
#endif
868868
{"background_log_sync", &srv_log_writes_and_flush, SHOW_SIZE_T},
869-
#if defined(LINUX_NATIVE_AIO)
870-
{"buffered_aio_submitted", &srv_stats.buffered_aio_submitted, SHOW_SIZE_T},
871-
#endif
872869
{"buffer_pool_dump_status",
873870
(char*) &export_vars.innodb_buffer_pool_dump_status, SHOW_CHAR},
874871
{"buffer_pool_load_status",

storage/innobase/include/srv0srv.h

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -81,10 +81,6 @@ struct srv_stats_t
8181
space in the log buffer and have to flush it */
8282
ulint_ctr_1_t log_waits;
8383

84-
#if defined(LINUX_NATIVE_AIO)
85-
ulint_ctr_1_t buffered_aio_submitted;
86-
#endif
87-
8884
/** Store the number of write requests issued */
8985
ulint_ctr_1_t buf_pool_write_requests;
9086

storage/innobase/os/os0file.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3963,7 +3963,6 @@ static bool is_linux_native_aio_supported()
39633963
}
39643964

39653965
int err = io_submit(io_ctx, 1, &p_iocb);
3966-
srv_stats.buffered_aio_submitted.inc();
39673966

39683967
if (err >= 1) {
39693968
/* Now collect the submitted IO request. */

0 commit comments

Comments
 (0)