Skip to content

Commit ead4147

Browse files
committed
- Reconize the JDBC type -7 (BIT)
modified: storage/connect/jdbconn.cpp - Add the global variable connect_java_wrapper This enables to use different wrappers modified: storage/connect/CMakeLists.txt renamed: storage/connect/java/ap/JdbcInterface.class -> storage/connect/JdbcApacheInterface.class renamed: storage/connect/java/ap/JdbcInterface.java -> storage/connect/JdbcApacheInterface.java renamed: storage/connect/java/ds/JdbcInterface.class -> storage/connect/JdbcDSInterface.class renamed: storage/connect/java/ds/JdbcInterface.java -> storage/connect/JdbcDSInterface.java modified: storage/connect/ha_connect.cc deleted: storage/connect/java/std/JdbcInterface.class deleted: storage/connect/java/std/JdbcInterface.java modified: storage/connect/jdbconn.cpp modified: storage/connect/jdbconn.h - Add JDBC tests (disabled) modified: storage/connect/mysql-test/connect/disabled.def new file: storage/connect/mysql-test/connect/r/jdbc.result new file: storage/connect/mysql-test/connect/r/jdbc_new.result new file: storage/connect/mysql-test/connect/r/jdbc_oracle.result new file: storage/connect/mysql-test/connect/r/jdbc_postgresql.result new file: storage/connect/mysql-test/connect/std_data/girls.txt new file: storage/connect/mysql-test/connect/t/jdbc.test new file: storage/connect/mysql-test/connect/t/jdbc_new.test new file: storage/connect/mysql-test/connect/t/jdbc_oracle.test new file: storage/connect/mysql-test/connect/t/jdbc_postgresql.test new file: storage/connect/mysql-test/connect/t/jdbconn.inc new file: storage/connect/mysql-test/connect/t/jdbconn_cleanup.inc - Typo modified: storage/connect/jsonudf.cpp
1 parent afa4657 commit ead4147

23 files changed

+1153
-737
lines changed

storage/connect/CMakeLists.txt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -240,7 +240,7 @@ OPTION(CONNECT_WITH_JDBC "Compile CONNECT storage engine with JDBC support" ON)
240240

241241
IF(CONNECT_WITH_JDBC)
242242
# TODO: detect Java SDK and the presence of JDBC connectors
243-
# TODO: Find how to compile and install the JdbcInterface.java class
243+
# TODO: Find how to compile and install the java wrapper class
244244
# Find required libraries and include directories
245245

246246
FIND_PACKAGE(Java)
@@ -251,6 +251,8 @@ IF(CONNECT_WITH_JDBC)
251251
# SET(JDBC_LIBRARY ${JAVA_JVM_LIBRARY})
252252
SET(CONNECT_SOURCES ${CONNECT_SOURCES}
253253
JdbcInterface.java JdbcInterface.class
254+
JdbcDSInterface.java JdbcDSInterface.class
255+
JdbcApacheInterface.java JdbcApacheInterface.class
254256
jdbconn.cpp tabjdbc.cpp jdbconn.h tabjdbc.h jdbccat.h)
255257
add_definitions(-DJDBC_SUPPORT)
256258
ELSE()

storage/connect/java/ap/JdbcInterface.java renamed to storage/connect/JdbcApacheInterface.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
import org.apache.commons.dbcp2.BasicDataSource;
88

9-
public class JdbcInterface {
9+
public class JdbcApacheInterface {
1010
boolean DEBUG = false;
1111
String Errmsg = "No error";
1212
Connection conn = null;
@@ -18,11 +18,11 @@ public class JdbcInterface {
1818
static Hashtable<String,BasicDataSource> pool = new Hashtable<String, BasicDataSource>();
1919

2020
// === Constructors/finalize =========================================
21-
public JdbcInterface() {
21+
public JdbcApacheInterface() {
2222
this(true);
2323
} // end of default constructor
2424

25-
public JdbcInterface(boolean b) {
25+
public JdbcApacheInterface(boolean b) {
2626
DEBUG = b;
2727
} // end of constructor
2828

@@ -706,4 +706,4 @@ static public int addLibraryPath(String pathToAdd) {
706706
} // end of addLibraryPath
707707
*/
708708

709-
} // end of class JdbcInterface
709+
} // end of class JdbcApacheInterface

storage/connect/java/ds/JdbcInterface.java renamed to storage/connect/JdbcDSInterface.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
import com.mysql.cj.jdbc.MysqlDataSource;
1212
import oracle.jdbc.pool.OracleDataSource;
1313

14-
public class JdbcInterface {
14+
public class JdbcDSInterface {
1515
boolean DEBUG = false;
1616
String Errmsg = "No error";
1717
Connection conn = null;
@@ -23,11 +23,11 @@ public class JdbcInterface {
2323
Hashtable<String,DataSource> dst = null;
2424

2525
// === Constructors/finalize =========================================
26-
public JdbcInterface() {
26+
public JdbcDSInterface() {
2727
this(true);
2828
} // end of default constructor
2929

30-
public JdbcInterface(boolean b) {
30+
public JdbcDSInterface(boolean b) {
3131
DEBUG = b;
3232
dst = new Hashtable<String, DataSource>();
3333
} // end of constructor
@@ -740,4 +740,4 @@ static public int addLibraryPath(String pathToAdd) {
740740
} // end of addLibraryPath
741741
*/
742742

743-
} // end of class JdbcInterface
743+
} // end of class JdbcDSInterface

storage/connect/ha_connect.cc

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -195,6 +195,7 @@ extern "C" {
195195
#if defined(JDBC_SUPPORT)
196196
char *JvmPath;
197197
char *ClassPath;
198+
char *Wrapper;
198199
#endif // JDBC_SUPPORT
199200

200201
#if defined(__WIN__)
@@ -6874,6 +6875,12 @@ static MYSQL_SYSVAR_STR(class_path, ClassPath,
68746875
"Java class path",
68756876
// check_class_path, update_class_path,
68766877
NULL, NULL, NULL);
6878+
6879+
static MYSQL_SYSVAR_STR(java_wrapper, Wrapper,
6880+
PLUGIN_VAR_RQCMDARG | PLUGIN_VAR_MEMALLOC,
6881+
"Java wrapper class",
6882+
// check_class_path, update_class_path,
6883+
NULL, NULL, "JdbcInterface");
68776884
#endif // JDBC_SUPPORT
68786885

68796886

@@ -6897,6 +6904,7 @@ static struct st_mysql_sys_var* connect_system_variables[]= {
68976904
#if defined(JDBC_SUPPORT)
68986905
MYSQL_SYSVAR(jvm_path),
68996906
MYSQL_SYSVAR(class_path),
6907+
MYSQL_SYSVAR(java_wrapper),
69006908
#endif // JDBC_SUPPORT
69016909
NULL
69026910
};
-14.9 KB
Binary file not shown.

0 commit comments

Comments
 (0)