Don't beep in mysql_upgrade_service.exe

vaintroub · vaintroub · commit f13c2107b39a · 2021-12-07T17:46:29.000+01:00
This beep looks especially strange, as mysqladmin output is redirected to
the log file
diff --git a/sql/mysql_upgrade_service.cc b/sql/mysql_upgrade_service.cc
@@ -464,8 +464,8 @@ int main(int argc, char **argv)
     if (WaitForSingleObject(mysqld_process, 0) != WAIT_TIMEOUT)
       die("mysqld.exe did not start");
 
-    if (run_tool(P_WAIT, mysqladmin_path, "--protocol=pipe",
-      socket_param, "ping",  NULL) == 0)
+    if (run_tool(P_WAIT, mysqladmin_path, "--protocol=pipe", socket_param,
+                 "ping", "--no-beep", NULL) == 0)
     {
       break;
     }

Original file line number	Diff line number	Diff line change
`@@ -464,8 +464,8 @@ int main(int argc, char **argv)`
`464`	`464`	`if (WaitForSingleObject(mysqld_process, 0) != WAIT_TIMEOUT)`
`465`	`465`	`die("mysqld.exe did not start");`
`466`	`466`
`467`		`- if (run_tool(P_WAIT, mysqladmin_path, "--protocol=pipe",`
`468`		`- socket_param, "ping", NULL) == 0)`
	`467`	`+ if (run_tool(P_WAIT, mysqladmin_path, "--protocol=pipe", socket_param,`
	`468`	`+ "ping", "--no-beep", NULL) == 0)`
`469`	`469`	`{`
`470`	`470`	`break;`
`471`	`471`	`}`