Skip to content

Commit f456532

Browse files
committed
MariaRocks port: compile RocksDB with -frtti.
Probably this is not the right way to do it, see the comment
1 parent 01a5216 commit f456532

File tree

1 file changed

+13
-0
lines changed

1 file changed

+13
-0
lines changed

storage/rocksdb/CMakeLists.txt

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,19 @@ INCLUDE_DIRECTORIES(
2525
ADD_DEFINITIONS(-DROCKSDB_PLATFORM_POSIX -DROCKSDB_LIB_IO_POSIX -DOS_LINUX
2626
-DZLIB)
2727

28+
# MARIAROCKS_NOT_YET: Add -frtti flag when compiling RocksDB files.
29+
# TODO: is this the right way to do this?
30+
# - SQL layer and storage/rocksdb/*.cc are compiled with -fnortti
31+
# - RocksDB files are compiled with "-fnortti ... -frtti"
32+
# - This causes RocksDB headers to be compiled with different settings:
33+
# = with RTTI when compiling RocksDB
34+
# = without RTTI when compiling storage/rocksdb/*.cc
35+
#
36+
# (facebook/mysql-5.6 just compiles everything without -f*rtti, which means
37+
# everything is compiled with -frtti)
38+
#
39+
set_source_files_properties(${ROCKSDB_LIB_SOURCES} PROPERTIES COMPILE_FLAGS -frtti)
40+
2841
SET(ROCKSDB_SOURCES
2942
ha_rocksdb.cc ha_rocksdb.h ha_rocksdb_proto.h
3043
logger.h

0 commit comments

Comments
 (0)