Skip to content

Commit

Permalink
MDEV-24916 : Assertion `current_stmt_binlog_format == BINLOG_FORMAT_S…
Browse files Browse the repository at this point in the history
…TMT || current_stmt_binlog_format == BINLOG_FORMAT_ROW' failed in THD::is_current_stmt_binlog_format_row

Store old value of binlog format before wsrep code so that
if we bail out because wsrep is not ready for connections
we can restore binlog format correctly.
  • Loading branch information
Jan Lindström committed Mar 16, 2021
1 parent 1ea6ac3 commit f4e4bff
Showing 1 changed file with 13 additions and 9 deletions.
22 changes: 13 additions & 9 deletions sql/sql_parse.cc
Original file line number Diff line number Diff line change
Expand Up @@ -3673,6 +3673,11 @@ mysql_execute_command(THD *thd)
Json_writer_object trace_command(thd);
Json_writer_array trace_command_steps(thd, "steps");

/* store old value of binlog format */
enum_binlog_format orig_binlog_format,orig_current_stmt_binlog_format;

thd->get_binlog_format(&orig_binlog_format,
&orig_current_stmt_binlog_format);
#ifdef WITH_WSREP
if (WSREP(thd))
{
Expand Down Expand Up @@ -3724,12 +3729,6 @@ mysql_execute_command(THD *thd)

DBUG_ASSERT(thd->transaction.stmt.modified_non_trans_table == FALSE);

/* store old value of binlog format */
enum_binlog_format orig_binlog_format,orig_current_stmt_binlog_format;

thd->get_binlog_format(&orig_binlog_format,
&orig_current_stmt_binlog_format);

/*
Assign system variables with values specified by the clause
SET STATEMENT var1=value1 [, var2=value2, ...] FOR <statement>
Expand Down Expand Up @@ -7552,9 +7551,14 @@ void THD::reset_for_next_command(bool do_clear_error)

save_prep_leaf_list= false;

DBUG_PRINT("debug",
("is_current_stmt_binlog_format_row(): %d",
is_current_stmt_binlog_format_row()));
#ifdef WITH_WSREP
#if !defined(DBUG_OFF)
if (mysql_bin_log.is_open())
#endif
#endif
DBUG_PRINT("debug",
("is_current_stmt_binlog_format_row(): %d",
is_current_stmt_binlog_format_row()));

DBUG_VOID_RETURN;
}
Expand Down

0 comments on commit f4e4bff

Please sign in to comment.