MDEV-37005 Unexpected ER_TABLE_EXISTS_ERROR on primary or replica upon CREATE OR REPLACE for partitioned table

cannot check thd->lex->part_info when a table is opened,
it can describe anything, not necessarily the table in question

Author: vuvova

mysql-test/suite/versioning/r/trx_id.result

@@ -595,3 +595,24 @@ ERROR HY000: Lock wait timeout exceeded; try restarting transaction
 disconnect con1;
 connection default;
 drop table t1;
+# End of 10.4 tests
+#
+# MDEV-37005 Unexpected ER_TABLE_EXISTS_ERROR on primary or replica upon CREATE OR REPLACE for partitioned table
+#
+create table t1 (
+a int,
+row_start bigint unsigned generated always as row start,
+row_end bigint unsigned generated always as row end,
+period for system_time (row_start, row_end)
+) engine=innodb with system versioning
+partition by hash (a);
+create or replace table t1 (b int) engine=innodb with system versioning partition by system_time;
+show create table t1;
+Table	Create Table
+t1	CREATE TABLE `t1` (
+  `b` int(11) DEFAULT NULL
+) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_uca1400_ai_ci WITH SYSTEM VERSIONING
+ PARTITION BY SYSTEM_TIME 
+PARTITIONS 2
+drop table t1;
+# End of 11.8 tests

mysql-test/suite/versioning/t/trx_id.test

@@ -643,3 +643,21 @@ alter table xx;
 --disconnect con1
 --connection default
 drop table t1;
+
+--echo # End of 10.4 tests
+
+--echo #
+--echo # MDEV-37005 Unexpected ER_TABLE_EXISTS_ERROR on primary or replica upon CREATE OR REPLACE for partitioned table
+--echo #
+create table t1 (
+  a int,
+  row_start bigint unsigned generated always as row start,
+  row_end bigint unsigned generated always as row end,
+  period for system_time (row_start, row_end)
+) engine=innodb with system versioning
+ partition by hash (a);
+create or replace table t1 (b int) engine=innodb with system versioning partition by system_time;
+show create table t1;
+drop table t1;
+
+--echo # End of 11.8 tests

sql/ha_partition.h

@@ -494,18 +494,10 @@ class ha_partition final :public handler
 
   bool vers_can_native(THD *thd) override
   {
-    if (thd->lex->part_info)
-    {
-      // PARTITION BY SYSTEM_TIME is not supported for now
-      return thd->lex->part_info->part_type != VERSIONING_PARTITION;
-    }
-    else
-    {
-      bool can= true;
-      for (uint i= 0; i < m_tot_parts && can; i++)
-        can= can && m_file[i]->vers_can_native(thd);
-      return can;
-    }
+    bool can= true;
+    for (uint i= 0; i < m_tot_parts && can; i++)
+      can= can && m_file[i]->vers_can_native(thd);
+    return can;
   }
 
   /*

sql/partition_info.h

@@ -487,7 +487,13 @@ bool partition_info::vers_fix_field_list(THD * thd)
     return true;
   }
   DBUG_ASSERT(part_type == VERSIONING_PARTITION);
-  DBUG_ASSERT(table->versioned(VERS_TIMESTAMP));
+  if (!table->versioned(VERS_TIMESTAMP))
+  {
+    my_error(ER_VERS_FIELD_WRONG_TYPE, MYF(0),
+             table->vers_start_field()->field_name.str,
+             "TIMESTAMP(6)", table->s->table_name.str);
+    return true;
+  }
 
   Field *row_end= table->vers_end_field();
   // needed in handle_list_of_fields()