MDEV-22659: Create one single unified and optimal logrotate config #2312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace mysql-log-rotate.sh and debian/...mysql-server.logrotate with one new unified and well documented version. Name is mariadb.logrotate.in as in 10.11 branch onward we use now the 'mariadb' name, and use 'logrotate' to match the actual name of the utility. Also automatically disable deprecated /etc/logrotate.d/mysql-server file on deb upgrades. Reviewer: Daniel Black Reviewer edits made: * Added 'su mysql mysql' to the logrotate this is more RPM friendly. This is commented on Debian * /var/log/mysql is the path on SuSe based distributions
|
Seems very solid to me. I don't find anything to add this. Better than the old one.. |
|
note included one packaging related postfix - d152609 |
grooverdan
removed
the
MariaDB Foundation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace mysql-log-rotate.sh and debian/...mysql-server.logrotate with one new unified and well documented version.
Name is mariadb.logrotate.in as in 10.11 branch onward we use now the 'mariadb' name, and use 'logrotate' to match the actual name of the utility.
Also automatically disable deprecated /etc/logrotate.d/mysql-server file on deb upgrades.
Reviewer: Daniel Black
Reviewer edits made:
Description
logrotate config was very dated and wasn't applicable to most distributions. There was also extensive mysql naming.
This was largely @ottok's work from #1556 however it needed to address RPM use cases and no change was forthcoming.
How can this PR be tested?
This now largely maps to the logrotate that Debian/Suse/Fedora/RHEL distribute so has had testing.