Allow using 'none' footer attribute in frontmatter #1002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crphang
suggested changes
Jan 31, 2020
src/Page.js
Outdated
| @@ -594,6 +594,12 @@ Page.prototype.insertHeaderFile = function (pageData) { | |||
| Page.prototype.insertFooterFile = function (pageData) { | |||
| const { footer } = this.frontMatter; | |||
| let footerFile; | |||
|
|
|||
| if (footer === 'none') { | |||
| // avoid adding any footer | |||
There was a problem hiding this comment.
will remove it 👍
src/Page.js
Outdated
| @@ -594,6 +594,12 @@ Page.prototype.insertHeaderFile = function (pageData) { | |||
| Page.prototype.insertFooterFile = function (pageData) { | |||
| const { footer } = this.frontMatter; | |||
| let footerFile; | |||
|
|
|||
| if (footer === 'none') { | |||
There was a problem hiding this comment.
if 'none' is a keyword, put it as a constant.
There was a problem hiding this comment.
will make the change 👍
There was a suggestion to extend this to other elements. I have no objections to that. I'll leave the decision to senior devs. |
yash-chowdhary
force-pushed
the
footer-none
branch
from
008996e
to
27c1a26
Compare
crphang
suggested changes
Feb 4, 2020
|
Ready for review |
crphang
approved these changes
Feb 15, 2020
Tejas2805
added a commit
to Tejas2805/markbind
that referenced
this pull request
Feb 27, 2020
* 'master' of https://github.com/MarkBind/markbind: Update tests Allow using 'none' footer attribute in frontmatter (MarkBind#1002) Support line numbers for code blocks (MarkBind#991) 2.11.0 Update test files due to changes in PR MarkBind#982 Update vue-strap version to v2.0.1-markbind.36 Make highlighting bold (MarkBind#1045) Support markdown for header attr in dropdown (MarkBind#1029) Add '_site' to the ignored folders in site.json (MarkBind#1046) Use path.join instead of string interpolation (MarkBind#1052) Implement box markdown header attributes parsing (MarkBind#1025) Make the position of top navbar fixed (MarkBind#982) Exclude *.md files from being copied over on build (MarkBind#1010) # Conflicts: # docs/css/main.css
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put "X" next to an item, remove the rest)
Fixes #638
What is the rationale for this request?
Enables users to exclude the footer that is derived/inherited from the layout specified in the
<frontmatter>.What changes did you make? (Give an overview)
Added a check for when the
footerattribute isnonewhile inserting the footer file into aPage.Testing instructions:
<frontmatter>footer: noneto<frontmatter>Expected output: Footer of the derived layout is omitted
Proposed commit message: (wrap lines at 72 characters)
Allow using 'none' footer attribute in frontmatter