Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add '_site' to the ignored folders in site.json #1046

Merged
merged 1 commit into from
Feb 22, 2020

Conversation

Tejas2805
Copy link
Contributor

What is the purpose of this pull request? (put "X" next to an item, remove the rest)

• [X] Enhancement to an existing feature

Fixes #587

What is the rationale for this request?

As per #587 , the default site.json generated during markbind init can be improved by ignoring _site

What changes did you make? (Give an overview)
Updated the default site.json that is generated by the markbind init command as follows:

  1. Added _site to the ignore array so that these files will be ignored while copying over to the generated site's directory.

Provide some example code that this change will affect:

const globPaths = addressableGlobs.reduce((globPages, addressableGlob) =>	      
  globPages.concat(walkSync(this.rootPath, {
    directories: false,
    globs: [addressableGlob.glob],
    ignore: [CONFIG_FOLDER_NAME, SITE_FOLDER_NAME],
}).map(globPath => ({
  src: globPath,
  searchable: addressableGlob.searchable,
  layout: addressableGlob.layout,
  frontmatter: addressableGlob.frontmatter,
}))), []);	

Is there anything you'd like reviewers to focus on?

N.A.

Testing instructions:

Run the test suite / build markbind locally and test

@Tejas2805
Copy link
Contributor Author

@marvinchin Can I get your review on this too? Thanks a lot for your time.

Copy link
Contributor

@marvinchin marvinchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Sorry for the delay, been pretty busy the last two weeks.

@yamgent yamgent merged commit c5a8df2 into MarkBind:master Feb 22, 2020
@yamgent yamgent added this to the v2.10.1 milestone Feb 22, 2020
Tejas2805 added a commit to Tejas2805/markbind that referenced this pull request Feb 27, 2020
* 'master' of https://github.com/MarkBind/markbind:
  Update tests
  Allow using 'none' footer attribute in frontmatter (MarkBind#1002)
  Support line numbers for code blocks (MarkBind#991)
  2.11.0
  Update test files due to changes in PR MarkBind#982
  Update vue-strap version to v2.0.1-markbind.36
  Make highlighting bold (MarkBind#1045)
  Support markdown for header attr in dropdown (MarkBind#1029)
  Add '_site' to the ignored folders in site.json (MarkBind#1046)
  Use path.join instead of string interpolation (MarkBind#1052)
  Implement box markdown header attributes parsing (MarkBind#1025)
  Make the position of top navbar fixed (MarkBind#982)
  Exclude *.md files from being copied over on build (MarkBind#1010)

# Conflicts:
#	docs/css/main.css
@Tejas2805 Tejas2805 deleted the add-_site-to-site.json branch February 27, 2020 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add '_site' to the ignored folders in site.json
3 participants