Use path.join instead of string interpolation #1052
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assuming forward slashes may cause errors on windows systems
What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [x] Bug fix
What is the rationale for this request?
This line was causing a error in tests as
createDir
uses string splitting based on thepath.sep
native to the OS.What changes did you make? (Give an overview)
Changed a path concatenation to use
path.join
instead of string interpolation.It was the only instance I could find in the entire project that was using string interpolation.
Provide some example code that this change will affect:
Should not have any changes
Is there anything you'd like reviewers to focus on?
Testing instructions:
Proposed commit message: (wrap lines at 72 characters)
Assuming forward slashes may cause errors on windows systems.
Let's use path.join to maintain cross platform compatibility.