Implement box markdown header attributes parsing #1025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ang-zeyu
force-pushed
the
box-header-parsing
branch
3 times, most recently
from
6410440
to
fb21dd0
Compare
ang-zeyu
force-pushed
the
box-header-parsing
branch
2 times, most recently
from
cc4ff29
to
bf0ac14
Compare
ang-zeyu
force-pushed
the
box-header-parsing
branch
from
bf0ac14
to
bce5336
Compare
|
Works. Good work @ang-zeyu and reviewers. |
Tejas2805
added a commit
to Tejas2805/markbind
that referenced
this pull request
Feb 27, 2020
* 'master' of https://github.com/MarkBind/markbind: Update tests Allow using 'none' footer attribute in frontmatter (MarkBind#1002) Support line numbers for code blocks (MarkBind#991) 2.11.0 Update test files due to changes in PR MarkBind#982 Update vue-strap version to v2.0.1-markbind.36 Make highlighting bold (MarkBind#1045) Support markdown for header attr in dropdown (MarkBind#1029) Add '_site' to the ignored folders in site.json (MarkBind#1046) Use path.join instead of string interpolation (MarkBind#1052) Implement box markdown header attributes parsing (MarkBind#1025) Make the position of top navbar fixed (MarkBind#982) Exclude *.md files from being copied over on build (MarkBind#1010) # Conflicts: # docs/css/main.css
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [x] Enhancement to an existing feature
Resolves #962
Requires MarkBind/vue-strap#118
Follow up to #999
What is the rationale for this request?
To add markdown parsing for box headings
What changes did you make? (Give an overview)
componentParserProvide some example code that this change will affect:
Markdown parsing for headers in
componentParser:Is there anything you'd like reviewers to focus on?
na
Testing instructions:
npm run testshould passProposed commit message: (wrap lines at 72 characters)
Implement box markdown header attributes parsing