Exclude *.md files from being copied over on build #1010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yamgent
reviewed
Feb 3, 2020
test/unit/Site.test.js
Outdated
| expect(fs.existsSync(path.resolve('inner/_site/markbind/layouts/default/footer.md'))).toEqual(false); | ||
| expect(fs.existsSync(path.resolve('inner/_site/markbind/layouts/default/head.md'))).toEqual(false); | ||
| expect(fs.existsSync(path.resolve('inner/_site/markbind/layouts/default/header.md'))).toEqual(false); | ||
| expect(fs.existsSync(path.resolve('inner/_site/markbind/layouts/default/navigation.md'))).toEqual(false); |
There was a problem hiding this comment.
I believe that these four lines can just be removed, since const expectedNumBuilt = 16; should already provide some assurance that these files cannot exist.
src/Site.js
Outdated
| fs.copyAsync(siteLayoutPath, layoutsDestPath) | ||
| .then(resolve) | ||
| .catch(reject); | ||
| glob(`${siteLayoutPath}/**/*`, (err, res) => { |
There was a problem hiding this comment.
We actually already have walk-sync which we use to walk through the files and directories. We can use that instead of using a brand new package.
|
Ready for review |
yamgent
approved these changes
Feb 15, 2020
|
@yash-chowdhary will need you to resolve the conflicts first, apologies for the delay. |
|
Done 👍 |
Tejas2805
added a commit
to Tejas2805/markbind
that referenced
this pull request
Feb 27, 2020
* 'master' of https://github.com/MarkBind/markbind: Update tests Allow using 'none' footer attribute in frontmatter (MarkBind#1002) Support line numbers for code blocks (MarkBind#991) 2.11.0 Update test files due to changes in PR MarkBind#982 Update vue-strap version to v2.0.1-markbind.36 Make highlighting bold (MarkBind#1045) Support markdown for header attr in dropdown (MarkBind#1029) Add '_site' to the ignored folders in site.json (MarkBind#1046) Use path.join instead of string interpolation (MarkBind#1052) Implement box markdown header attributes parsing (MarkBind#1025) Make the position of top navbar fixed (MarkBind#982) Exclude *.md files from being copied over on build (MarkBind#1010) # Conflicts: # docs/css/main.css
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [x] Bug fix
Fixes #825
What is the rationale for this request?
Prevents
.mdfiles in the_markbind/layoutsdirectory from being copied over on building the_site. Copies over the rest of the file types..mddo not need to be copied because they are supposed to be rendered by MarkBind.What changes did you make? (Give an overview)
Filtered out the
.mdfiles from the list of files to be copied.Provide some example code that this change will affect:
Testing instructions:
npm run testTest sites have been updated to reflect
.mdfiles not being copied overProposed commit message: (wrap lines at 72 characters)
Exclude .md files from being copied over on build