Use event listener to restore header on expand window #1933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahtanjz
reviewed
May 23, 2022
There was a problem hiding this comment.
Thanks for contributing to MarkBind @elroygohjy 👍
One suggestion, other than that it looks good.
packages/core-web/src/index.js
Outdated
Comment on lines
55
to
60
| window.addEventListener('resize', () => { | ||
| if (window.innerWidth > 767 && headerSelector.hasClass('hide-header')) { | ||
| headerSelector.removeClass('hide-header'); | ||
| headerSelector.css('overflow', ''); | ||
| } | ||
| }); |
There was a problem hiding this comment.
Maybe can shift this out of the toggleHeaderOnScroll method to line 110 so that this event listener is only added once?
There was a problem hiding this comment.
Yep, I refactored it.
jonahtanjz
approved these changes
May 23, 2022
|
@all-contributors please add @elroygohjy for code |
|
I've put up a pull request to add @elroygohjy! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Overview of changes:
Fixes #1922
Anything you'd like to highlight / discuss:
I added event listener to listen resize event, as apparently window's innerwidth remains unchanged on clicking the expand window button.
Testing instructions:
Navbar reappears on expanding window/pressing expanding window button.
Proposed commit message: (wrap lines at 72 characters)
Fix navbar disappearing on expanding window