Fix image linkify and alt attribute #2046
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Overview of changes:
Fixes #2045
Fixes #2028
Addressing two related issues on images
![]()
Anything you'd like to highlight/discuss:
The default markdown image syntax seems to overlap with the features of the
pic
component, and some features exist on one and not the other. I think it is still important to support the default syntax since it's a very common usage. Further improvements can be done to the image support in the future.Testing instructions:
Proposed commit message: (wrap lines at 72 characters)
Fix image linkify and alt attribute
Currently the image linkify feature is not documented and does
not account for already wrapped images. The image alternative
text is also not captured due to outdated markdown-it-imsize.
Let's document the linkify feature and update the relevant
packages to fix the issues. Let's also add tests to ensure the
functionalities are captured and verified.
Checklist: ☑️