Add bootswatch theme specific tip box styles #999
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put "X" next to an item, remove the rest)
• [x] Enhancement to an existing feature
Resolves #962
Accompanying pull request to MarkBind/vue-strap#118
What is the rationale for this request?
To add tweak tip box heading styling and add theme specific styles for said headings, as good looking headings is difficult to achieve on all themes with generic styling.
What changes did you make? (Give an overview)
Preview (uses theme's alert-xx color)
Preview (theme-specific color):
Provide some example code that this change will affect:
Is there anything you'd like reviewers to focus on?
The implementation of theme specific styles ( #997 ),
mainly whether bootswatch should be patched directly.
Testing instructions:
markbind serve -d
to launch the template page with all the variants of the tip boxes.npm run updatetest
should pass ( number of assets generated unit test is changed, and expected test files )Proposed commit message: (wrap lines at 72 characters)
Add bootswatch theme specific tip box styles