feat(caching): separate package #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basmasking
reviewed
Mar 15, 2023
| { | ||
| MODULE_PATTERN: '**/*.js', | ||
| SEGMENT_PATTERN: '**/*.segment.json', | ||
| NODE_SEGMENT_PATTERN: '**/*.node.segment.js', |
There was a problem hiding this comment.
The pattern doesn't match the pattern created in the function below.
basmasking
reviewed
Mar 17, 2023
| } | ||
| catch (error: unknown) | ||
| { | ||
| throw new SegmentFileNotLoaded(filename); |
There was a problem hiding this comment.
Should we do something with the actual error to make it clear what went wrong before throwing a customized error?
basmasking
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #155
Changes proposed in this pull request:
@MaskingTechnology/jitar