Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(security): secure module loading #243

Merged
merged 5 commits into from
Apr 12, 2023
Merged

bug(security): secure module loading #243

merged 5 commits into from
Apr 12, 2023

Conversation

petermasking
Copy link
Member

Fixes #242

Changes proposed in this pull request:

  • Check if the URL stays within the base URL (project folder)

@MaskingTechnology/jitar

@petermasking petermasking linked an issue Apr 12, 2023 that may be closed by this pull request
Secure the module loading system #242
Closed
basmasking
basmasking requested changes Apr 12, 2023
View reviewed changes
Copy link
Member

@basmasking basmasking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

naming convention?

@basmasking basmasking merged commit 7617167 into main Apr 12, 2023
@basmasking basmasking deleted the 242-secure-the-module-loading-system branch April 12, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basmasking basmasking basmasking approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Secure the module loading system
2 participants
@petermasking @basmasking