Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(build): added sonar for linting #339

Merged
merged 4 commits into from
Jul 12, 2023
Merged

chore(build): added sonar for linting #339

merged 4 commits into from
Jul 12, 2023

Conversation

basmasking
Copy link
Member

@basmasking basmasking commented Jul 12, 2023 •
edited
Loading

Fixes #334

Changes proposed in this pull request:

  • Added sonarjs to eslint
  • Fixed issues raised by sonarjs

@MaskingTechnology/jitar

@basmasking basmasking changed the title added sonar dependency chore(build): added sonar for linting Jul 12, 2023
@basmasking basmasking marked this pull request as ready for review July 12, 2023 14:21
@petermasking petermasking merged commit 5c9754e into main Jul 12, 2023
@petermasking petermasking deleted the sonar-eslint branch July 12, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petermasking petermasking petermasking approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add sonarjs to eslint
2 participants
@basmasking @petermasking