fix(runtime): fixed incorrect parsing of return values #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petermasking
requested changes
Jan 30, 2024
| @@ -3,7 +3,9 @@ import checkSecret from '../game/checkSecret'; | |||
|
|
|||
| export default async function guessSecret(secret: string): Promise<string> | |||
There was a problem hiding this comment.
Suggested change
| export default async function guessSecret(secret: string): Promise<string> | |
| export default async function guessSecret(secret: number): Promise<string> |
Is this a good idea? It feels more logical to me. The only consequence is that we have to change the requests from GET to POST so we can provide the correct content type.
|
|
||
| import { REQUESTS } from '../_fixtures/services/Remote.fixture'; | ||
|
|
||
| const remote = new Remote('http://localhost:3000'); |
There was a problem hiding this comment.
Should we create the remote in the fixture?
petermasking
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #451
Changes proposed in this pull request:
@MaskingTechnology/jitar