New reloading development server #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephmancuso
requested changes
Nov 9, 2018
masonite/commands/ServeCommand.py
Outdated
| ]) | ||
|
|
||
| # monitor the env file too | ||
| reloader.watch_files(['.env']) |
There was a problem hiding this comment.
This line of code is never reached
There was a problem hiding this comment.
Wow, their docs really messed that one up. I'll get this fixed.
…ork/core into revamp-development-server
|
Made a slight modification. There was an issue where a file not found was being thrown. Apparently i think the loader is local to the commands directory? prepending the cwd to the file did the trick.
|
josephmancuso
requested changes
Nov 14, 2018
josephmancuso
approved these changes
Nov 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was chatting with @josephmancuso and found several issues regarding the quality of waitress + our old code reloading system. We found that the development experience could be greatly improved by changing it out with this instead.
The improvements are:
I've tested this on both Mac OSX and Ubuntu. I would appreciate if somebody could test this on Windows. It wouldn't hurt to have somebody confirm that it works on both Mac and Linux again too.