Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed acceptfiles issue #513

Merged
merged 6 commits into from
Jan 2, 2019
Merged

fixed acceptfiles issue #513

merged 6 commits into from
Jan 2, 2019

Conversation

josephmancuso
Copy link
Member

@josephmancuso josephmancuso commented Jan 1, 2019 •
edited
Loading

This PR fixes an issue where s3 would throw an exception if the filename and location were both supplied

  • This PR also adds the feature that the upload disk driver will create the directory if it does not exist
  • This PR also makes all Amazon s3 uploads store to a storage/temp directory
  • Also bumps up the exception thrown higher in the code to prevent failed uploads but successful file storage if the boto3 library is not installed

@coveralls
Copy link

coveralls commented Jan 1, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 89.729% when pulling 4c5548c on hotfix-s3-driver into 3528998 on 2.1.

@josephmancuso josephmancuso merged commit 5173451 into 2.1 Jan 2, 2019
@josephmancuso josephmancuso deleted the hotfix-s3-driver branch January 10, 2019 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josephmancuso @coveralls