spring cleaning #522
spring cleaning #522
Conversation
| """HTTP Middleware | ||
| HTTP middleware is middleware that will be ran on every request. Middleware | ||
| is only ran when a HTTP call is successful (a 200 response). This list | ||
| should contain a simple aggregate of middleware classes. | ||
| """ | ||
|
|
||
| HTTP_MIDDLEWARE = [ | ||
| LoadUserMiddleware, | ||
| # todo | ||
| # CsrfMiddleware, |
There was a problem hiding this comment.
@josephmancuso FYI. I have kept it as todo.
There was a problem hiding this comment.
I mean I kept it as it is. it commented out when I am doing spring cleaning.
| handler = logging.StreamHandler() | ||
| handler.setFormatter(formatter) | ||
|
|
||
| logger.addHandler(handler) |
There was a problem hiding this comment.
I'm not sure but they are in masonite repo.
https://github.com/MasoniteFramework/masonite/blob/8f7a289e1e918b58c1115d669bea8fbe9b8a8a68/config/database.py#L55
There was a problem hiding this comment.
🤔 i'm not sure why i added these .... lol
There was a problem hiding this comment.
is it related to logger driver?
There was a problem hiding this comment.
no it's suppose to show the queries in the terminal (so you can optimize) but i thought thats what the DB_LOG was doing .. lol
There was a problem hiding this comment.
not sure why i added this extra code
There was a problem hiding this comment.
we can keep it for now and remove it later.
| """HTTP Middleware | ||
| HTTP middleware is middleware that will be ran on every request. Middleware | ||
| is only ran when a HTTP call is successful (a 200 response). This list | ||
| should contain a simple aggregate of middleware classes. | ||
| """ | ||
|
|
||
| HTTP_MIDDLEWARE = [ | ||
| LoadUserMiddleware, | ||
| # todo | ||
| # CsrfMiddleware, |
|
@josephmancuso Now it is failing at session, did i miss something? |
config/session.py
Outdated
| """ | ||
|
|
||
| DRIVER = os.getenv('SESSION_DRIVER', 'memory') | ||
| DRIVER = env('SESSION_DRIVER', 'cookie') |
There was a problem hiding this comment.
possibly this change from cookie to memory?
There was a problem hiding this comment.
this shouldn't break it tho but i wonder if this is breaking it
There was a problem hiding this comment.
No it does not, memory works.
There was a problem hiding this comment.
hmm i'm gonna need to bring that in later and make sure nothing is wrong with that
vaibhavmule
force-pushed
the
vaibhavmule-spring-cleaning
branch
from
20d447d
to
8df4046
Compare
tests are successfully except for
tests/testing/test_unit_test.pyandtests/test_upload_manager.py@josephmancuso can you have a look?