Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create auth.register method #709

Merged
merged 8 commits into from
May 19, 2019
Merged

create auth.register method #709

merged 8 commits into from
May 19, 2019

Conversation

vaibhavmule
Copy link
Contributor

No description provided.

@vaibhavmule
Copy link
Contributor Author

Note: This needs to be to do after #694

@vaibhavmule vaibhavmule marked this pull request as ready for review May 18, 2019 16:17
@vaibhavmule vaibhavmule changed the base branch from 2.1 to develop May 18, 2019 16:18
@coveralls
Copy link

coveralls commented May 18, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.04%) to 87.167% when pulling e131188 on auth-rework into f6f39b6 on develop.

@josephmancuso
Copy link
Member

With the new DatabaseTestCase class we can add legit database tests. I added one and found an issue with one of your lines. you were doing a == instead of an assignment (=)

@josephmancuso
Copy link
Member

not a problem though :) thats what tests are for

@josephmancuso josephmancuso merged commit 10793e0 into develop May 19, 2019
@josephmancuso josephmancuso deleted the auth-rework branch August 29, 2019 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephmancuso josephmancuso josephmancuso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vaibhavmule @coveralls @josephmancuso