Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/465 - Adds API module back into Masonite #468

Merged
merged 22 commits into from
Dec 28, 2021
Merged

Feature/465 - Adds API module back into Masonite #468

merged 22 commits into from
Dec 28, 2021

Conversation

josephmancuso
Copy link
Member

No description provided.

girardinsamuel
girardinsamuel suggested changes Dec 26, 2021
View reviewed changes
Copy link
Contributor

@girardinsamuel girardinsamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is a quick review !

src/masonite/api/Api.py Outdated Show resolved Hide resolved
src/masonite/api/commands/APIInstallCommand.py Outdated Show resolved Hide resolved
src/masonite/api/commands/APIInstallCommand.py Show resolved Hide resolved
tests/features/api/test_api.py Outdated Show resolved Hide resolved
tests/features/api/test_api.py Outdated Show resolved Hide resolved
src/masonite/input/InputBag.py Show resolved Hide resolved
@josephmancuso
Copy link
Member Author

Fixed JWT Guard

@josephmancuso
Copy link
Member Author

Also fixed a big issue where routes weren't even aloud to have multiple middleware stacks assigned to them

josephmancuso
josephmancuso commented Dec 27, 2021
View reviewed changes
Copy link
Member Author

@josephmancuso josephmancuso left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed myself. Why can't we approve our own PR's?

@josephmancuso josephmancuso merged commit c6e4473 into 4.0 Dec 28, 2021
@girardinsamuel girardinsamuel deleted the feature/465 branch December 28, 2021 08:14
@renovate renovate bot mentioned this pull request Dec 30, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@girardinsamuel girardinsamuel girardinsamuel requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josephmancuso @girardinsamuel